From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933062AbaICVby (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Sep 2014 17:31:54 -0400
Received: from v094114.home.net.pl ([79.96.170.134]:58510 "HELO
	v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S932327AbaICVbw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Sep 2014 17:31:52 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] acpi: fan.c: printk replacement
Date: Wed, 03 Sep 2014 23:51:12 +0200
Message-ID: <13181466.m5lsFWfZvz@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/3.16.0-rc5+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1409233639-9165-1-git-send-email-sudipm.mukherjee@gmail.com>
References: <1409233639-9165-1-git-send-email-sudipm.mukherjee@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday, August 28, 2014 07:17:19 PM Sudip Mukherjee wrote:
> printk replaced with corresponding dev_err and dev_info 
> fixed one broken user-visible string 
> multiine comment edited for correct commenting style 
> asm/uaccess.h replaced with linux/uaccess.h
> PREFIX removed
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> 
> modified with reference to the discussion at https://lkml.org/lkml/2014/8/22/176 

Queued up for 3.18, thanks!

>  drivers/acpi/fan.c | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
> index 8acf53e..5328b10 100644
> --- a/drivers/acpi/fan.c
> +++ b/drivers/acpi/fan.c
> @@ -27,12 +27,10 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> -#include <asm/uaccess.h>
> +#include <linux/uaccess.h>
>  #include <linux/thermal.h>
>  #include <linux/acpi.h>
>  
> -#define PREFIX "ACPI: "
> -
>  #define ACPI_FAN_CLASS			"fan"
>  #define ACPI_FAN_FILE_STATE		"state"
>  
> @@ -127,8 +125,9 @@ static const struct thermal_cooling_device_ops fan_cooling_ops = {
>  };
>  
>  /* --------------------------------------------------------------------------
> -                                 Driver Interface
> -   -------------------------------------------------------------------------- */
> + *                               Driver Interface
> + * --------------------------------------------------------------------------
> +*/
>  
>  static int acpi_fan_add(struct acpi_device *device)
>  {
> @@ -143,7 +142,7 @@ static int acpi_fan_add(struct acpi_device *device)
>  
>  	result = acpi_bus_update_power(device->handle, NULL);
>  	if (result) {
> -		printk(KERN_ERR PREFIX "Setting initial power state\n");
> +		dev_err(&device->dev, "Setting initial power state\n");
>  		goto end;
>  	}
>  
> @@ -168,10 +167,9 @@ static int acpi_fan_add(struct acpi_device *device)
>  				   &device->dev.kobj,
>  				   "device");
>  	if (result)
> -		dev_err(&device->dev, "Failed to create sysfs link "
> -			"'device'\n");
> +		dev_err(&device->dev, "Failed to create sysfs link 'device'\n");
>  
> -	printk(KERN_INFO PREFIX "%s [%s] (%s)\n",
> +	dev_info(&device->dev, "ACPI: %s [%s] (%s)\n",
>  	       acpi_device_name(device), acpi_device_bid(device),
>  	       !device->power.state ? "on" : "off");
>  
> @@ -217,7 +215,7 @@ static int acpi_fan_resume(struct device *dev)
>  
>  	result = acpi_bus_update_power(to_acpi_device(dev)->handle, NULL);
>  	if (result)
> -		printk(KERN_ERR PREFIX "Error updating fan power state\n");
> +		dev_err(dev, "Error updating fan power state\n");
>  
>  	return result;
>  }
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.