From: Paul Bolle <pebolle@tiscali.nl>
To: Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <padovan@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Bluetooth: btusb: handle usb_submit_urb error similarly
Date: Sun, 09 Oct 2011 12:11:30 +0200 [thread overview]
Message-ID: <1318155090.1903.22.camel@x61.thuisdomein> (raw)
0) These two patches are follow-ups to commit
4935f1c164ac528dff3538f97953b385ba500710 ("Bluetooth: btusb: be quiet on
device disconnect"). One difference with that commit is that I stopped
adding comments explaining -EPERM and -ENODEV, because it seemed a bit
silly to repeat those comments that often.
1) Note that I haven't actually ever seen the errors I now hide (in case
of "urb is being killed" or "device got disconnected") in the second
patch, so I'd appreciate a more careful review of that patch.
2) Also note that there's a call of usb_submit_urb() in play_deferred()
which never prints an error. Should it do that if usb_submit_urb()
returns a negative value?
Paul Bolle (2):
Bluetooth: btusb: also be quiet when suspending
Bluetooth: btusb: hide more usb_submit_urb errors
drivers/bluetooth/btusb.c | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)
--
1.7.4.4
reply other threads:[~2011-10-09 10:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318155090.1903.22.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®