From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: jacob.jun.pan@intel.com, mingo@elte.hu,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: [PATCH] x86, ioapic: only print ioapic debug information for IRQs belonging to an ioapic chip
Date: Mon, 10 Oct 2011 17:00:36 +0300 [thread overview]
Message-ID: <1318255236-6389-1-git-send-email-mathias.nyman@linux.intel.com> (raw)
with "apic=verbose" the print_IO_APIC() function tries to print IRQ to pin mappings
for every active irq. It assumes chip_data is of type irq_cfg and may cause an oops if not.
As the print_IO_APIC() is called from a late_initcall other chained irq chips may already be
registered with custom chip_data information, causing an oops. This is the case with intel
MID SoC devices with gpio demuxers registered as irq_chips.
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
arch/x86/kernel/apic/io_apic.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 472e094..0a37ec0 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1499,6 +1499,7 @@ __apicdebuginit(void) print_IO_APIC(void)
unsigned long flags;
struct irq_cfg *cfg;
unsigned int irq;
+ struct irq_chip *chip;
printk(KERN_DEBUG "number of MP IRQ sources: %d.\n", mp_irq_entries);
for (i = 0; i < nr_ioapics; i++)
@@ -1618,6 +1619,10 @@ __apicdebuginit(void) print_IO_APIC(void)
for_each_active_irq(irq) {
struct irq_pin_list *entry;
+ chip = irq_get_chip(irq);
+ if (chip != &ioapic_chip && chip != &ir_ioapic_chip)
+ continue;
+
cfg = irq_get_chip_data(irq);
if (!cfg)
continue;
--
1.7.4.1
reply other threads:[~2011-10-10 14:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318255236-6389-1-git-send-email-mathias.nyman@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=jacob.jun.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®