From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790Ab1JJPUy (ORCPT ); Mon, 10 Oct 2011 11:20:54 -0400 Received: from perches-mx.perches.com ([206.117.179.246]:49550 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751734Ab1JJPUw (ORCPT ); Mon, 10 Oct 2011 11:20:52 -0400 Message-ID: <1318260051.25811.12.camel@Joe-Laptop> Subject: Re: [PATCH 5/6] udf: Neaten logging output, use vsprintf extension %pV From: Joe Perches To: Jan Kara Cc: NamJae Jeon , linux-kernel@vger.kernel.org Date: Mon, 10 Oct 2011 08:20:51 -0700 In-Reply-To: <20111010150444.GD3944@quack.suse.cz> References: <20111010150444.GD3944@quack.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.0- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-10-10 at 17:04 +0200, Jan Kara wrote: > On Mon 10-10-11 01:08:06, Joe Perches wrote: > > Remove the warning and error prefixes that duplicate KERN_. > Please keep that in the prefix. It's easier to read messages when they > are that way ... I think duplicating kernel standard functionality is not good and this merely increases logging buffer size. It's your code, you're the maintainer, fix it up as you choose.