From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951Ab1JLG11 (ORCPT ); Wed, 12 Oct 2011 02:27:27 -0400 Received: from mga09.intel.com ([134.134.136.24]:45427 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470Ab1JLG10 (ORCPT ); Wed, 12 Oct 2011 02:27:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="62396204" Subject: Re: [PATCHv4] DMAEngine: Define interleaved transfer request api From: Vinod Koul To: Barry Song <21cnbao@gmail.com> Cc: Jassi Brar , "Williams, Dan J" , Russell King , linux-kernel@vger.kernel.org, DL-SHA-WorkGroupLinux , Dave Jiang In-Reply-To: References: <1317191992-3635-1-git-send-email-jaswinder.singh@linaro.org> <1317200618.1573.1765.camel@vkoul-udesk3> <1317295068.1573.1780.camel@vkoul-udesk3> <20111003161349.GB28287@flint.arm.linux.org.uk> <1317966346.1573.2252.camel@vkoul-udesk3> <1317997177.1573.2275.camel@vkoul-udesk3> <1318229592.1573.2298.camel@vkoul-udesk3> <1318238296.1546.3.camel@vkoul-udesk3> <1318243501.1546.12.camel@vkoul-udesk3> <1318262559.1546.31.camel@vkoul-udesk3> Content-Type: text/plain; charset="UTF-8" Date: Wed, 12 Oct 2011 11:49:28 +0530 Message-ID: <1318400368.1546.372.camel@vkoul-udesk3> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-10-12 at 13:41 +0800, Barry Song wrote: > 2011/10/11 Jassi Brar : > > On 10 October 2011 21:32, Vinod Koul wrote: > >> On Mon, 2011-10-10 at 16:46 +0530, Jassi Brar wrote: > >>> On 10 October 2011 16:15, Vinod Koul wrote: > >>> > > >>> > But I am fine if we find a common ground and merge the two where dmac > >>> > can cleanly identify direction and mode it is operating. > >>> > > >>> The client would set the xfer_direction and dmac would interpret as > >>> > >>> enum xfer_direction { > >>> MEM_TO_MEM, -> Async/Memcpy mode > >>> MEM_TO_DEV, -> Slave mode & From Memory to Device > >>> DEV_TO_MEM, -> Slave mode & From Device to Memory > >>> DEV_TO_DEV, -> Slave mode & From Device to Device > >>> } > >>> > >>> How could it get any cleaner? > >> Consider the case of a dmac driver which supports interleaved dma as > >> well as memcpy and slave > >> It needs to interpret dma_data_direction for later cases and > >> xfer_direction for former ones. > > dma_data_direction is the mapping attribute of a buffer and is not meant to > > tell type of source and destination of a transfer. > > xfer_direction is meant for that purpose. > > So I'd rather convert device_prep_dma_cyclic and device_prep_slave_sg > > to use xfer_direction. > > i tend to agree with Jassi. now dma_data_direction actually is only > mapping things not real transfer direction. > xfer_direction is now something really telling the data transfer direction. > I think that's what device_prep_dma_cyclic and device_prep_slave_sg want. > > actually, there is only one case we need to use dma_data_direction in > dmac driver, that's unmapping async dma buffer. > But the param to dma_unmap_single can be implied by xfer_direction and > dma description. > > that's why i think we should rename dma_data_direction to > dma_map_direction or something like that to avoid confusion. Nope, I would leave dma_data_direction as is. We should use above enum in dmaengine and all dmac drivers. @Jassi: I have started doing this change for dmaengine and dmacs, and I took the liberty to name this enum as dma_transfer_direction, hope you are okay with that -- ~Vinod