From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751974Ab1JMShJ (ORCPT ); Thu, 13 Oct 2011 14:37:09 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:59072 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699Ab1JMShH (ORCPT ); Thu, 13 Oct 2011 14:37:07 -0400 X-Authority-Analysis: v=1.1 cv=XWD5/VRj2HUJOhsR8cgmvPBlhMACpZXxseY1Kn/ehQI= c=1 sm=0 a=jVLHYovT1_cA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=ZycB6UtQUfgMyuk2+PxD7w==:17 a=tHz9FfFoAAAA:8 a=hCfZMxHQRGL6TjOjB64A:9 a=PUjeQqilurYA:10 a=6O0IECtVFhoA:10 a=ZycB6UtQUfgMyuk2+PxD7w==:117 X-Cloudmark-Score: 0 X-Originating-IP: 74.67.80.29 Message-ID: <1318531022.12224.13.camel@gandalf.stny.rr.com> Subject: Re: [PATCH RFC V4 09/10] x86/jump_label: use GENERIC_NOP5_ATOMIC instead of jmp5 +0 From: Steven Rostedt To: Jeremy Fitzhardinge Cc: "H. Peter Anvin" , "David S. Miller" , David Daney , Michael Ellerman , Jan Glauber , Jason Baron , the arch/x86 maintainers , Xen Devel , Linux Kernel Mailing List , Ingo Molnar , Peter Zijlstra , Jeremy Fitzhardinge Date: Thu, 13 Oct 2011 14:37:02 -0400 In-Reply-To: <4E97188A.6040400@goop.org> References: <34ede5db1571d541a5c3fc49923bb353a37dd431.1318464413.git.jeremy.fitzhardinge@citrix.com> <4E97067A.2070305@zytor.com> <4E97188A.6040400@goop.org> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.0.3-2 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-10-13 at 09:57 -0700, Jeremy Fitzhardinge wrote: > On 10/13/2011 08:40 AM, H. Peter Anvin wrote: > > On 10/12/2011 05:08 PM, Jeremy Fitzhardinge wrote: > >> From: Jeremy Fitzhardinge > >> > >> GENERIC_NOP5_ATOMIC should make a better nop. > >> > > On 32 bits, yes. On 64 bits you should use P6_NOP5_ATOMIC. > > Something like this? > No, we only care about 5byte nops here. Look at ideal_nop in alterative.c -- Steve