From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046Ab1JNPpg (ORCPT ); Fri, 14 Oct 2011 11:45:36 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:42800 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757Ab1JNPpe (ORCPT ); Fri, 14 Oct 2011 11:45:34 -0400 Subject: Re: [PATCH v2 00/29] Create PCI root buses with correct resources From: James Bottomley To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20111014042142.23504.70417.stgit@bhelgaas.mtv.corp.google.com> <1318605254.3018.20.camel@dabdike.int.hansenpartnership.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 14 Oct 2011 10:45:32 -0500 Message-ID: <1318607132.3018.30.camel@dabdike.int.hansenpartnership.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2011-10-14 at 09:33 -0600, Bjorn Helgaas wrote: > On Fri, Oct 14, 2011 at 9:14 AM, James Bottomley > wrote: > > On Thu, 2011-10-13 at 22:27 -0600, Bjorn Helgaas wrote: > >> The most generic way to create a PCI root bus is with pci_scan_bus(), but > >> that doesn't allow you to specify what resources are available on the bus, > >> i.e., what the host bridge apertures are. > > > > Do you have an actual tree for this? The PARISC pieces look a bit > > non-trivial and I'd like to test them out on the various sba/astro/dino > > systems. > > I don't yet, but it'd be great if you were willing to test them out, > so I'll set one up. > > While this is on your mind, I'm dubious about the pci_enable_bridges() > call in lba_driver_probe() and the pci_bus_assign_resources() call in > dino_probe(). These stand out as exceptions because no other arches > do that. > > If they weren't there, both places could use pci_scan_root_bus() like > most other arches. Right, the dino code actually has to rearrange some of the PCI resources to make sure we get our apertures correct. That's the specific bit I was planning to test. I think it's only relevant for dino SBA cards where the bridge doesn't set up the card correctly so we have to do it after the fact. James