From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751883Ab1JOImC (ORCPT ); Sat, 15 Oct 2011 04:42:02 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:35013 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054Ab1JOImA (ORCPT ); Sat, 15 Oct 2011 04:42:00 -0400 From: Namjae Jeon To: jack@suse.cz Cc: linux-kernel@vger.kernel.org, Namjae Jeon , Ashish Sangwan Subject: [PATCH v2] udf : skip finding mirror meta in same location with metadata. Date: Sat, 15 Oct 2011 17:41:46 +0900 Message-Id: <1318668106-2147-1-git-send-email-linkinjeon@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If metadata duplicate flag is clear, it means there is mirror metadata file in same location with metadata file. So this patch try to skip finding mirror partition on this case. Mount time is improved and avoid unnecessarily loading mirror metadata. Signed-off-by: Ashish Sangwan Signed-off-by: Namjae Jeon --- fs/udf/super.c | 51 +++++++++++++++++++++++++++++++-------------------- 1 files changed, 31 insertions(+), 20 deletions(-) diff --git a/fs/udf/super.c b/fs/udf/super.c index e58123a..f76f9e6 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -857,28 +857,39 @@ static int udf_load_metadata_files(struct super_block *sb, int partition) mdata->s_metadata_fe = NULL; } - /* mirror file entry */ - addr.logicalBlockNum = mdata->s_mirror_file_loc; - addr.partitionReferenceNum = map->s_partition_num; + if (!mdata->s_dup_md_flag) { + udf_info("There is mirror metadata file in same location with metadata file."); + if (fe_error) { + udf_err(sb, "So mirror inode efe can not found too"); + goto error_exit; + } else { + mdata->s_mirror_fe = mdata->s_metadata_fe; + } + } else { - udf_debug("Mirror metadata file location: block = %d part = %d\n", - addr.logicalBlockNum, addr.partitionReferenceNum); + /* mirror file entry */ + addr.logicalBlockNum = mdata->s_mirror_file_loc; + addr.partitionReferenceNum = map->s_partition_num; - mdata->s_mirror_fe = udf_iget(sb, &addr); + udf_debug("Mirror metadata file location: block = %d part = %d\n", + addr.logicalBlockNum, addr.partitionReferenceNum); - if (mdata->s_mirror_fe == NULL) { - if (fe_error) { - udf_err(sb, "mirror inode efe not found and metadata inode is missing too, exiting...\n"); - goto error_exit; - } else - udf_warn(sb, "mirror inode efe not found, but metadata inode is OK\n"); - } else if (UDF_I(mdata->s_mirror_fe)->i_alloc_type != - ICBTAG_FLAG_AD_SHORT) { - udf_warn(sb, "mirror inode efe does not have short allocation descriptors!\n"); - iput(mdata->s_mirror_fe); - mdata->s_mirror_fe = NULL; - if (fe_error) - goto error_exit; + mdata->s_mirror_fe = udf_iget(sb, &addr); + + if (mdata->s_mirror_fe == NULL) { + if (fe_error) { + udf_err(sb, "mirror inode efe not found and metadata inode is missing too, exiting...\n"); + goto error_exit; + } else + udf_warn(sb, "mirror inode efe not found, but metadata inode is OK\n"); + } else if (UDF_I(mdata->s_mirror_fe)->i_alloc_type != + ICBTAG_FLAG_AD_SHORT) { + udf_warn(sb, "mirror inode efe does not have short allocation descriptors!\n"); + iput(mdata->s_mirror_fe); + mdata->s_mirror_fe = NULL; + if (fe_error) + goto error_exit; + } } /* -- 1.7.4.4