mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: David Rientjes <rientjes@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [patch] parisc, iommu: add missing include for prefetchw()
Date: Sat, 15 Oct 2011 18:48:19 -0500	[thread overview]
Message-ID: <1318722499.7271.54.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1110151536310.25063@chino.kir.corp.google.com>

On Sat, 2011-10-15 at 15:38 -0700, David Rientjes wrote:
> prefetchw() requires it to be defined by linux/prefetch.h, or it results
> in a compile error:
> 
> In file included from drivers/parisc/sba_iommu.c:916:0:
> drivers/parisc/iommu-helpers.h: In function 'iommu_fill_pdir':
> drivers/parisc/iommu-helpers.h:62:4: error: implicit declaration of function 'prefetchw'
> 
> Include linux/prefetch.h.

This isn't physically possible on the parisc platform: prefetch.h is
included by processor.h which, amongst other things, goes into
spinlock.h which is above this file in sba_iommu.c

How did you try to compile this file?

James



  reply	other threads:[~2011-10-15 23:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 23:38 Please include const-sections into linux-next Andi Kleen
2011-10-14  0:04 ` Stephen Rothwell
2011-10-14 22:26 ` James Bottomley
2011-10-15 22:38   ` [patch] parisc, iommu: add missing include for prefetchw() David Rientjes
2011-10-15 23:48     ` James Bottomley [this message]
2011-10-16  0:41       ` David Rientjes
2011-10-16  0:56         ` James Bottomley
2011-10-16  1:15           ` David Rientjes
2011-10-15 23:03   ` Please include const-sections into linux-next David Rientjes
2011-10-15 23:49     ` James Bottomley
2011-10-16  0:53       ` David Rientjes
2011-10-16  0:58         ` James Bottomley
2011-10-16  3:35   ` Andi Kleen
2011-10-16 21:03     ` James Bottomley
2011-10-16 21:57       ` Andi Kleen
2011-10-19 15:54         ` James Bottomley
2011-10-19 16:15           ` Andi Kleen
2011-10-19 16:21             ` James Bottomley
2011-10-19 16:33               ` Andi Kleen
2011-10-19 18:55                 ` James Bottomley
2011-10-19 19:05                   ` Andi Kleen
2011-10-19 20:04                     ` James Bottomley
2011-10-19 20:06                       ` James Bottomley
2011-10-19 20:11                         ` Andi Kleen
2011-10-19 20:14                           ` James Bottomley
2011-10-19 21:24                             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318722499.7271.54.camel@dabdike.int.hansenpartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=andi@firstfloor.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®