From: Mandeep Singh Baines <msb@chromium.org>
To: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>
Cc: Hugh Dickins <hughd@chromium.org>,
Hugh Dickins <hughd@google.com>,
Mandeep Singh Baines <msb@chromium.org>,
Dave Airlie <airlied@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
dri-devel@lists.freedesktop.org
Subject: [PATCH] drm: avoid switching to text console if there is no panic timeout
Date: Mon, 17 Oct 2011 17:06:40 -0700 [thread overview]
Message-ID: <1318896400-32498-1-git-send-email-msb@chromium.org> (raw)
From: Hugh Dickins <hughd@chromium.org>
Add a check for panic_timeout in the drm_fb_helper_panic() notifier: if
we're going to reboot immediately, the user will not be able to see the
messages anyway, and messing with the video mode may display artifacts,
and certainly get into several layers of complexity (including mutexes and
memory allocations) which we shall be much safer to avoid.
Signed-off-by: Hugh Dickins <hughd@google.com>
[ Edited commit message and modified to short-circuit panic_timeout < 0
instead of testing panic_timeout >= 0. -Mandeep ]
Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/drm_fb_helper.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index f7c6854..0e62c93 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -254,6 +254,13 @@ bool drm_fb_helper_force_kernel_mode(void)
int drm_fb_helper_panic(struct notifier_block *n, unsigned long ununsed,
void *panic_str)
{
+ /*
+ * It's a waste of time and effort to switch back to text console
+ * if the kernel should reboot before panic messages can be seen.
+ */
+ if (panic_timeout < 0)
+ return 0;
+
printk(KERN_ERR "panic occurred, switching back to text console\n");
return drm_fb_helper_force_kernel_mode();
}
--
1.7.3.1
next reply other threads:[~2011-10-18 0:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 0:06 Mandeep Singh Baines [this message]
2011-10-18 0:27 ` David Rientjes
2011-11-10 20:50 ` David Rientjes
2011-11-10 21:15 ` Mandeep Singh Baines
2011-11-10 21:29 ` Dave Airlie
2011-11-10 21:51 ` Andrew Morton
2011-10-18 1:33 ` Stéphane Marchesin
2011-10-18 2:19 ` Dave Young
2011-10-18 2:22 ` Dave Young
2011-10-18 18:29 ` Mandeep Singh Baines
2011-10-19 1:07 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318896400-32498-1-git-send-email-msb@chromium.org \
--to=msb@chromium.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hughd@chromium.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®