From: Guan Xuetao <gxt@mprc.pku.edu.cn>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
David Rientjes <rientjes@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH] unicore32: EXPORT_SYMBOL needs export.h
Date: Tue, 18 Oct 2011 18:36:48 +0800 [thread overview]
Message-ID: <1318934208.1789.48.camel@epip-laptop> (raw)
In-Reply-To: <1318927906.25468.2.camel@phoenix>
It seems the same problem with cross-compiler.
And I can't produce the same warnings.
Thanks Axel.
Guan Xuetao
On Tue, 2011-10-18 at 16:51 +0800, Axel Lin wrote:
> Include export.h to fix below warning:
>
> CC arch/unicore32/mm/init.o
> arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class
> arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This patch is against linux-next 20111014.
> export.h only exist in Paul's tree now.
> I think this patch should route via Paul's module.h splitup tree.
>
> Axel
> arch/unicore32/mm/init.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/unicore32/mm/init.c b/arch/unicore32/mm/init.c
> index 2d3e711..3b379cd 100644
> --- a/arch/unicore32/mm/init.c
> +++ b/arch/unicore32/mm/init.c
> @@ -20,6 +20,7 @@
> #include <linux/memblock.h>
> #include <linux/sort.h>
> #include <linux/dma-mapping.h>
> +#include <linux/export.h>
>
> #include <asm/sections.h>
> #include <asm/setup.h>
next prev parent reply other threads:[~2011-10-18 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 8:51 Axel Lin
2011-10-18 10:36 ` Guan Xuetao [this message]
2011-10-18 13:32 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318934208.1789.48.camel@epip-laptop \
--to=gxt@mprc.pku.edu.cn \
--cc=arnd@arndb.de \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®