From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Xu, Anhua" <anhua.xu@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: perf tools: interface for improved PEBS ABI can accept wrong parameter
Date: Tue, 18 Oct 2011 20:28:21 +0200 [thread overview]
Message-ID: <1318962501.14880.6.camel@twins> (raw)
In-Reply-To: <20111018181943.GC21666@elte.hu>
On Tue, 2011-10-18 at 20:19 +0200, Ingo Molnar wrote:
> > +#define SAMPLE_IP_MAX 3
> > precise_ip : 2, /* skid constraint */
> > mmap_data : 1, /* non-exec mmap data */
> > sample_id_all : 1, /* sample_type all events */
> > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> > index 928918b..a2068cc 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -775,7 +775,10 @@ parse_event_modifier(const char **strp, struct perf_event_attr *attr)
> > attr->exclude_user = eu;
> > attr->exclude_kernel = ek;
> > attr->exclude_hv = eh;
> > - attr->precise_ip = precise;
> > + if ( precise < SAMPLE_IP_MAX )
> > + attr->precise_ip = precise;
> > + else
> > + return -1;
That name is horrid, how about PRECISE_IP_MAX? Also, I suspect acme will
want a better error return than -1, but I'll leave that up to him.
next prev parent reply other threads:[~2011-10-18 18:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 14:31 Xu, Anhua
2011-10-18 18:19 ` Ingo Molnar
2011-10-18 18:28 ` Peter Zijlstra [this message]
2011-10-19 2:23 ` Xu, Anhua
2011-10-19 3:06 ` Chen Gong
2011-10-19 14:15 ` Arnaldo Carvalho de Melo
2011-10-23 17:07 ` Xu, Anhua
-- strict thread matches above, loose matches on Subject: below --
2011-10-18 14:20 Xu, Anhua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318962501.14880.6.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=anhua.xu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome