From: Joe Perches <joe@perches.com>
To: David Rientjes <rientjes@google.com>,
Wolfram Sang <w.sang@pengutronix.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch
Date: Tue, 18 Oct 2011 17:01:09 -0700 [thread overview]
Message-ID: <1318982469.7569.1.camel@Joe-Laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1110181643450.8149@chino.kir.corp.google.com>
On Tue, 2011-10-18 at 16:44 -0700, David Rientjes wrote:
> On Tue, 18 Oct 2011, Jonathan Cameron wrote:
> > This started happening when I run checkpatch on pretty much anything.
> > triggered by the b in this snipped for example
> > diff --git a/arch/arm/mach-pxa/stargate2.c b/arch/arm/mach-pxa/stargate2.c
> > index 3f8d0af..62dc2a8 100644
> > --- a/arch/arm/mach-pxa/stargate2.c
> > +++ b/arch/arm/mach-pxa/stargate2.c
> > @@ -54,6 +54,8 @@
> > #include <linux/mfd/da903x.h>
> > Anyone else seeing this or have a clue what the heck is going on?
It's done this since:
$ git log -1 1e85572697b348b1a126520349a29654f2ae6a12
commit 1e85572697b348b1a126520349a29654f2ae6a12
Author: Wolfram Sang <w.sang@pengutronix.de>
Date: Tue Jan 6 14:41:24 2009 -0800
checkpatch: Add warning for p0-patches
Some people work internally with -p0-patches which has the danger that one
forgets to convert them to -p1 before mainlining. Bitten myself and seen
p0-patches in mailing lists occasionally, this patch adds a warning to
checkpatch.pl in case a patch is -p0. If you really want, you can fool
this check to generate false positives, this is why it just spits a
warning. Making the check 100% proof is trickier than it looks, so let's
start with a version which catches the cases of real use.
[apw@canonical.com: update message language, handle null prefix, add tests]
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
I've always ignored it.
next prev parent reply other threads:[~2011-10-19 0:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 15:03 Jonathan Cameron
2011-10-18 23:44 ` David Rientjes
2011-10-19 0:01 ` Joe Perches [this message]
2011-10-19 1:27 ` David Rientjes
2011-10-19 8:27 ` Jonathan Cameron
2011-10-19 10:26 ` Wolfram Sang
2011-10-19 11:04 ` Jonathan Cameron
2011-10-19 11:22 ` Wolfram Sang
2011-10-19 11:32 ` Jonathan Cameron
2011-10-19 16:17 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318982469.7569.1.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®