mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	"Michael S.Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3] virtio: Add platform bus driver for memory mapped virtio device
Date: Fri, 21 Oct 2011 18:57:24 +0100	[thread overview]
Message-ID: <1319219844.5094.16.camel@hornet.cambridge.arm.com> (raw)
In-Reply-To: <87ty75adtb.fsf@rustcorp.com.au>

On Wed, 2011-10-19 at 03:57 +0100, Rusty Russell wrote:
> > Oh, really? My host-side implementation is just doing that:
> > 
> >         addr += align - 1;
> >         addr &= ~(align - 1);
> 
> OK, so you're assuming power of 2.  Make sure you kill the guest or at
> least the device if it's not though.

Yep, I have assertions all around such places :-) (it's a non-production
code yet so I can do that)

> > \item The dynamic configuration changes, as described in p. 2.4.3
> > ``Dealing With Configuration Changes'' are not permitted.
> 
> This means some devices simply won't work, at least in theory.  Why
> don't you support this?

Uh. I simply forgot about it - my Host block device doesn't do that, so
I ignored that feature initially and then it slipped through cracks. And
till now I didn't realize that most of the drivers actually use this :-O
My fault.

Simple to fix anyway - I'll just add InterruptStatus register and use
second bit (same with InterruptACK) to get this through. Will be done on
Monday.

Any other final complaints regarding the interface while I'm on it? ;-)

Cheers!

Paweł



  reply	other threads:[~2011-10-21 17:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 13:47 [PATCH] " Pawel Moll
2011-09-28 13:54 ` Pawel Moll
2011-10-03 23:46 ` Rusty Russell
2011-10-04 16:16   ` Pawel Moll
2011-10-05  1:10     ` Rusty Russell
2011-10-05 10:06       ` Pawel Moll
2011-10-05 18:57         ` [PATCH v2] " Pawel Moll
2011-10-06 16:50           ` [PATCH v3] " Pawel Moll
2011-10-06 17:13             ` Pawel Moll
2011-10-18  4:09               ` Rusty Russell
2011-10-18  9:44                 ` Pawel Moll
2011-10-19  2:57                   ` Rusty Russell
2011-10-21 17:57                     ` Pawel Moll [this message]
2011-10-24  2:33                       ` Rusty Russell
2011-10-24 13:06                         ` Pawel Moll
2011-10-24 13:07                           ` [PATCH v4] " Pawel Moll
2011-10-25  1:13                             ` Rusty Russell
2011-10-26  4:06                           ` [PATCH v3] " Rusty Russell
     [not found]                             ` <1319612222.2878.4.camel@rojo>
2011-10-26 11:50                               ` Rusty Russell
2011-10-13 16:49             ` Pawel Moll
2011-10-05 10:39       ` [PATCH] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319219844.5094.16.camel@hornet.cambridge.arm.com \
    --to=pawel.moll@arm.com \
    --cc=aliguori@us.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®