From: Deng-Cheng Zhu <dczhu@mips.com>
To: <linux-kernel@vger.kernel.org>
Cc: Deng-Cheng Zhu <dczhu@mips.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [RFC PATCH 1/2] tools/perf: Don't set attr->disabled when doing grouping
Date: Mon, 24 Oct 2011 18:56:59 +0800 [thread overview]
Message-ID: <1319453820-12992-2-git-send-email-dczhu@mips.com> (raw)
In-Reply-To: <1319453820-12992-1-git-send-email-dczhu@mips.com>
Events will be created at the state PERF_EVENT_STATE_OFF if attr->disabled
is set. When these events go to arch level validate_group(), the function
won't do anything real because they are filtered out by the state check.
Signed-off-by: Deng-Cheng Zhu <dczhu@mips.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
tools/perf/builtin-record.c | 6 +++---
tools/perf/builtin-stat.c | 3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index f4c3fbe..67e8e4c 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -161,7 +161,6 @@ static void config_attr(struct perf_evsel *evsel, struct perf_evlist *evlist)
struct perf_event_attr *attr = &evsel->attr;
int track = !evsel->idx; /* only the first counter needs these */
- attr->disabled = 1;
attr->inherit = !no_inherit;
attr->read_format = PERF_FORMAT_TOTAL_TIME_ENABLED |
PERF_FORMAT_TOTAL_TIME_RUNNING |
@@ -222,10 +221,11 @@ static void config_attr(struct perf_evsel *evsel, struct perf_evlist *evlist)
attr->mmap = track;
attr->comm = track;
- if (target_pid == -1 && target_tid == -1 && !system_wide) {
+ if (!group)
attr->disabled = 1;
+
+ if (target_pid == -1 && target_tid == -1 && !system_wide)
attr->enable_on_exec = 1;
- }
}
static bool perf_evlist__equal(struct perf_evlist *evlist,
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 5deb17d..ca95475 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -284,7 +284,8 @@ static int create_perf_stat_counter(struct perf_evsel *evsel)
return perf_evsel__open_per_cpu(evsel, evsel_list->cpus, group);
if (target_pid == -1 && target_tid == -1) {
- attr->disabled = 1;
+ if (!group)
+ attr->disabled = 1;
attr->enable_on_exec = 1;
}
--
1.7.1
next prev parent reply other threads:[~2011-10-24 10:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 10:56 [RFC PATCH 0/2] tools/perf: fix the event grouping functionality Deng-Cheng Zhu
2011-10-24 10:56 ` Deng-Cheng Zhu [this message]
2011-10-24 14:19 ` [RFC PATCH 1/2] tools/perf: Don't set attr->disabled when doing grouping David Ahern
2011-10-25 7:26 ` Peter Zijlstra
2011-10-24 10:57 ` [RFC PATCH 2/2] tools/perf: Make group_fd static and move its place in __perf_evsel__open() Deng-Cheng Zhu
2011-10-24 14:03 ` Arnaldo Carvalho de Melo
2011-10-25 15:23 ` Arnaldo Carvalho de Melo
2011-10-26 6:26 ` Deng-Cheng Zhu
2011-10-26 11:18 ` Arnaldo Carvalho de Melo
2011-10-26 11:21 ` Arnaldo Carvalho de Melo
2011-10-26 13:14 ` Zhu, DengCheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319453820-12992-2-git-send-email-dczhu@mips.com \
--to=dczhu@mips.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®