From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: dmitry.torokhov@gmail.com, grant.likely@secretlab.ca,
sameo@linux.intel.com, peter.ujfalusi@ti.com, jic23@cam.ac.uk,
aghayal@codeaurora.org, david@hardeman.nu, Shubhrajyoti@ti.com,
saaguirre@ti.com, hemanthv@ti.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCHv4 2/6] input/cma3000_d0x: Check silicon version
Date: Mon, 24 Oct 2011 22:21:12 +0200 [thread overview]
Message-ID: <1319487676-27181-3-git-send-email-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <1319487676-27181-1-git-send-email-ricardo.ribalda@gmail.com>
Improve probing of the cma3000 chip, by checking the revision of the
device.
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
---
v4: Add ACKs to patch
v2: Fixes suggested by Jonathan Cameron
-Remove WhoamI pr_info
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/input/misc/cma3000_d0x.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
index e66036d..97e36fa 100644
--- a/drivers/input/misc/cma3000_d0x.c
+++ b/drivers/input/misc/cma3000_d0x.c
@@ -27,6 +27,8 @@
#include "cma3000_d0x.h"
+#define CMA3000_REV 0x10
+
#define CMA3000_WHOAMI 0x00
#define CMA3000_REVID 0x01
#define CMA3000_CTRL 0x02
@@ -420,7 +422,11 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
error = rev;
goto err_free_mem;
}
-
+ if (rev != CMA3000_REV) {
+ error = -EINVAL;
+ pr_err("CMA3000 Accelerometer: Unknown Revision %x\n", rev);
+ goto err_free_mem;
+ }
pr_info("CMA3000 Accelerometer: Revision %x\n", rev);
error = request_threaded_irq(irq, NULL, cma3000_thread_irq,
--
1.7.7
next prev parent reply other threads:[~2011-10-24 20:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 20:21 [PATCHv4 0/6] Add spi support for CMA3000 driver and new driver CMR3000 Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 1/6] input/cma3000_d0x: Support devices without pdata Ricardo Ribalda Delgado
2011-10-24 21:31 ` Grant Likely
2011-10-25 7:38 ` Ricardo Ribalda Delgado
2011-10-25 7:46 ` Grant Likely
2011-11-02 12:41 ` Ricardo Ribalda Delgado
2011-11-02 14:51 ` Ricardo Ribalda Delgado
2011-10-24 20:21 ` Ricardo Ribalda Delgado [this message]
2011-10-24 20:21 ` [PATCHv4 3/6] input/cma3000_d0x: Keep configuration on poweroff Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support Ricardo Ribalda Delgado
2011-10-24 21:36 ` Grant Likely
2011-10-25 7:24 ` Ricardo Ribalda Delgado
2011-10-25 8:29 ` Grant Likely
2011-10-25 8:32 ` Jonathan Cameron
2011-10-25 8:36 ` Mark Brown
2011-11-02 12:38 ` Ricardo Ribalda Delgado
2011-11-02 12:49 ` Mark Brown
2011-10-24 20:21 ` [PATCHv4 5/6] Input: add CMR3000 gyrsocope driver Ricardo Ribalda Delgado
2011-10-24 21:40 ` Grant Likely
2011-10-25 7:26 ` Ricardo Ribalda Delgado
2011-10-25 8:28 ` Grant Likely
2011-11-02 14:28 ` Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 6/6] input/cma3000_d0x: Match comment to name of struct Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319487676-27181-3-git-send-email-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=Shubhrajyoti@ti.com \
--cc=aghayal@codeaurora.org \
--cc=david@hardeman.nu \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=hemanthv@ti.com \
--cc=jic23@cam.ac.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=saaguirre@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®