>From wey-yi.w.guy@intel.com Thu Oct 27 18:33:38 2011 Received: from orsmga001.jf.intel.com (10.7.209.18) by orsmsx601-2.jf.intel.com (10.22.226.227) with Microsoft SMTP Server id 8.2.255.0; Thu, 27 Oct 2011 18:33:38 -0700 Received: from wwguy-ubuntu.jf.intel.com (HELO localhost.localdomain) ([134.134.163.140]) by orsmga001.jf.intel.com with ESMTP; 27 Oct 2011 18:33:37 -0700 From: "Guy, Wey-Yi W" To: "internal-wifi-devel@linux.intel.com" CC: "Guy, Wey-Yi W" Date: Thu, 27 Oct 2011 18:27:37 -0700 Subject: [PATCH 1/1] iwlwifi: don't perform "echo test" when cmd queue stuck Thread-Topic: [PATCH 1/1] iwlwifi: don't perform "echo test" when cmd queue stuck Thread-Index: AcyVEZ0ZiK9yfGaFSzWWZs6J/t6gXg== Message-ID: <1319765257-24424-1-git-send-email-wey-yi.w.guy@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Exchange-Organization-AuthAs: Internal X-MS-Exchange-Organization-AuthMechanism: 10 X-MS-Exchange-Organization-AuthSource: orsmsx601.amr.corp.intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ironport-av: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="68757522" x-extloop1: 1 Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-Evolution-Source: imap://wwguy@imapmail.intel.com/ Content-Transfer-Encoding: 8bit From: Wey-Yi Guy Perform "echo test" when cmd queue stuck detected, somethime it will cause calltrace. I am not sure how to fix it yet, just remove the action now until find a better way to handle it. Signed-off-by: Wey-Yi Guy --- drivers/net/wireless/iwlwifi/iwl-core.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c index a779024..8efa10f 100644 --- a/drivers/net/wireless/iwlwifi/iwl-core.c +++ b/drivers/net/wireless/iwlwifi/iwl-core.c @@ -1450,16 +1450,6 @@ static inline int iwl_check_stuck_queue(struct iwl_priv *priv, int txq) { if (iwl_trans_check_stuck_queue(trans(priv), txq)) { int ret; - if (txq == priv->shrd->cmd_queue) { - /* - * validate command queue still working - * by sending "ECHO" command - */ - if (!iwl_cmd_echo_test(priv)) - return 0; - else - IWL_DEBUG_HC(priv, "echo testing fail\n"); - } ret = iwl_force_reset(priv, IWL_FW_RESET, false); return (ret == -EAGAIN) ? 0 : 1; } -- 1.7.0.4