mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: <grabner@icg.tugraz.at>
Cc: <devel@linuxdriverproject.org>, <linux-kernel@vger.kernel.org>,
	Stefan Hajnoczi <stefanha@gmail.com>
Subject: [PATCH 1/2] staging: line6: accept all MIDI channels by default
Date: Sun, 30 Oct 2011 14:40:40 +0000	[thread overview]
Message-ID: <1319985641-25648-2-git-send-email-stefanha@gmail.com> (raw)
In-Reply-To: <1319985641-25648-1-git-send-email-stefanha@gmail.com>

MIDI messages can be filtered by channel so that multiple devices can
coexist on the same MIDI bus.  By default all channels should be
accepted; this is important because Line6 devices seem to have different
default channels.

Accept all MIDI messages by default to avoid confusing users when
messages are silently filtered out.  If filtering is necessary due to
multiple devices on the bus, users can set the midi_mask_transmit and
midi_mask_receive sysfs attributes.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
---
 drivers/staging/line6/midi.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/line6/midi.c b/drivers/staging/line6/midi.c
index e554a2d..2d81d2a 100644
--- a/drivers/staging/line6/midi.c
+++ b/drivers/staging/line6/midi.c
@@ -399,8 +399,8 @@ int line6_init_midi(struct usb_line6 *line6)
 		return err;
 
 	line6midi->line6 = line6;
-	line6midi->midi_mask_transmit = 1;
-	line6midi->midi_mask_receive = 4;
+	line6midi->midi_mask_transmit = 0xffff;
+	line6midi->midi_mask_receive = 0xffff;
 	line6->line6midi = line6midi;
 
 	err = snd_device_new(line6->card, SNDRV_DEV_RAWMIDI, line6midi,
-- 
1.7.7


  reply	other threads:[~2011-10-30 14:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-30 14:40 [PATCH 0/2] staging: line6: add Pod HD300 support Stefan Hajnoczi
2011-10-30 14:40 ` Stefan Hajnoczi [this message]
2011-10-30 14:40 ` [PATCH 2/2] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319985641-25648-2-git-send-email-stefanha@gmail.com \
    --to=stefanha@gmail.com \
    --cc=devel@linuxdriverproject.org \
    --cc=grabner@icg.tugraz.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome