From: Shannon Nelson <shannon.nelson@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, rob.gardner@oracle.com,
netdev@vger.kernel.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc
Date: Thu, 12 Jan 2017 12:56:08 -0800 [thread overview]
Message-ID: <131ec7b7-5b74-2545-8bf7-92812443a876@oracle.com> (raw)
In-Reply-To: <20170112.154143.1940764507974590907.davem@davemloft.net>
On 1/12/2017 12:41 PM, David Miller wrote:
> From: Shannon Nelson <shannon.nelson@oracle.com>
> Date: Thu, 12 Jan 2017 12:30:38 -0800
>
>> On 1/12/2017 12:25 PM, Eric Dumazet wrote:
>>> On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote:
>>>
>>>>
>>>> I suspect that someplace, somebody is casting val to an int * or
>>>> something like that.
>>>
>>> Then that would be the bug. Can we root cause this please ?
>>>
>>>
>>
>> Look in net/ipv4/tcp_fastopen.c:tcp_fastopen_cookie_gen() for the line
>>
>> struct in6_addr *buf = (struct in6_addr *) tmp.val;
>
> Oh yeah, that's it. I didn't notice that at all.
>
It looked to me like swapping the data fields would be the easiest and
least impactive way to fix this. I didn't want to mess with the logic.
I'm certainly open to other suggestions.
sln
next prev parent reply other threads:[~2017-01-12 20:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 19:59 Shannon Nelson
2017-01-12 20:13 ` Eric Dumazet
2017-01-12 20:15 ` Rob Gardner
2017-01-12 20:25 ` Eric Dumazet
2017-01-12 20:30 ` Shannon Nelson
2017-01-12 20:41 ` David Miller
2017-01-12 20:56 ` Shannon Nelson [this message]
2017-01-12 21:18 ` David Miller
2017-01-12 21:36 ` Eric Dumazet
2017-01-12 21:47 ` David Miller
2017-01-12 21:58 ` Shannon Nelson
2017-01-12 21:58 ` David Miller
2017-01-12 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131ec7b7-5b74-2545-8bf7-92812443a876@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rob.gardner@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®