From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>,
robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run,
marijn.suijten@somainline.org, airlied@gmail.com,
daniel@ffwll.ch, quic_jesszhan@quicinc.com,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] drm/msm: Remove redundant DRM_DEV_ERROR()
Date: Wed, 2 Aug 2023 12:35:49 +0300 [thread overview]
Message-ID: <131f9c51-10d6-c4b4-4e7f-c3c30480d385@linaro.org> (raw)
In-Reply-To: <20230727112407.2916029-1-ruanjinjie@huawei.com>
On 27/07/2023 14:24, Ruan Jinjie wrote:
> There is no need to call the DRM_DEV_ERROR() function directly to print
> a custom message when handling an error from platform_get_irq() function
> as it is going to display an appropriate error message
> in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
> drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 1 -
> drivers/gpu/drm/msm/msm_gpu.c | 1 -
> 2 files changed, 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-08-02 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 11:24 Ruan Jinjie
2023-08-02 9:35 ` Dmitry Baryshkov [this message]
2023-08-02 9:55 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131f9c51-10d6-c4b4-4e7f-c3c30480d385@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=ruanjinjie@huawei.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®