From: Thieu Le <thieule@chromium.org>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Thieu Le <thieule@chromium.org>
Subject: [PATCH] vfs: Export fallocate facility to kernel modules
Date: Mon, 31 Oct 2011 12:14:05 -0700 [thread overview]
Message-ID: <1320088445-12373-1-git-send-email-thieule@chromium.org> (raw)
Export fallocate facility so layered file systems such as ecryptfs can
take advantage of this feature. One example of the need for fallocate
is by ecryptfs. ecryptfs has recently switched to a writeback cache
model so its dirty pages are not written to the lower file system
immediately. In order to ensure that space is available when the page
is later written, ecryptfs can efficiently preallocate that space using
vfs_fallocate().
vfs_fallocate() does not perform all of the checkings of do_fallocate()
because those checks are done higher in the stack. Checking of offset and
len are done by rw_verify_area() and generic_write_checks(). These
functions are called by VFS before ecryptfs invokes vfs_fallocate() in its
ecryptfs_write_end() function. And since ecryptfs directly opens the lower
file, it ensures that the file is opened with the proper flags and mode.
Signed-off-by: Thieu Le <thieule@chromium.org>
---
fs/open.c | 14 ++++++++++----
include/linux/fs.h | 2 ++
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/fs/open.c b/fs/open.c
index f711921..8a4ba20 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -214,6 +214,15 @@ SYSCALL_ALIAS(sys_ftruncate64, SyS_ftruncate64);
#endif /* BITS_PER_LONG == 32 */
+int vfs_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
+{
+ if (!file->f_op->fallocate)
+ return -EOPNOTSUPP;
+
+ return file->f_op->fallocate(file, mode, offset, len);
+}
+EXPORT_SYMBOL(vfs_fallocate);
+
int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
{
struct inode *inode = file->f_path.dentry->d_inode;
@@ -263,10 +272,7 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
if (((offset + len) > inode->i_sb->s_maxbytes) || ((offset + len) < 0))
return -EFBIG;
- if (!file->f_op->fallocate)
- return -EOPNOTSUPP;
-
- return file->f_op->fallocate(file, mode, offset, len);
+ return vfs_fallocate(file, mode, offset, len);
}
SYSCALL_DEFINE(fallocate)(int fd, int mode, loff_t offset, loff_t len)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 277f497..c0e1225 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1504,6 +1504,8 @@ extern int vfs_link(struct dentry *, struct inode *, struct dentry *);
extern int vfs_rmdir(struct inode *, struct dentry *);
extern int vfs_unlink(struct inode *, struct dentry *);
extern int vfs_rename(struct inode *, struct dentry *, struct inode *, struct dentry *);
+extern int vfs_fallocate(struct file *file, int mode, loff_t offset,
+ loff_t len);
/*
* VFS dentry helper functions.
--
1.7.3.1
next reply other threads:[~2011-10-31 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 19:14 Thieu Le [this message]
2011-11-02 7:53 ` Christoph Hellwig
2011-11-02 21:27 ` Thieu Le
2011-11-05 12:30 ` Tyler Hicks
2011-11-05 17:04 ` Tyler Hicks
2011-11-16 20:22 ` Thieu Le
2011-11-18 19:53 ` Tyler Hicks
2011-11-21 18:55 ` Thieu Le
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320088445-12373-1-git-send-email-thieule@chromium.org \
--to=thieule@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®