Re: [PATCH] Stageing: bcm: fixed spacing coding style in led_control.c

[Paul Bolle <pebolle@tiscali.nl>]

Stageing? And you might as well drop the filename from the summary. By
the way, are the other files (if any) of this driver any better (I
haven't checked)?

On Tue, 2011-11-01 at 10:44 +0000, Ciaran McCormick wrote:
> ---
>  drivers/staging/bcm/led_control.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c
> index 16e939f..28c3382 100644
> --- a/drivers/staging/bcm/led_control.c
> +++ b/drivers/staging/bcm/led_control.c
> @@ -5,8 +5,8 @@
>  
>  static B_UINT16 CFG_CalculateChecksum(B_UINT8 *pu8Buffer, B_UINT32 u32Size)
>  {
> -	B_UINT16 	u16CheckSum=0;
> -	while(u32Size--) {
> +	B_UINT16	u16CheckSum = 0;
> +	while (u32Size--) {
>  		u16CheckSum += (B_UINT8)~(*pu8Buffer);

I'd say this line might need a space after the cast.

>  	    pu8Buffer++;
>  	}
> @@ -16,7 +16,7 @@ BOOLEAN IsReqGpioIsLedInNVM(PMINI_ADAPTER Adapter, UINT gpios)
>  {
>  	INT Status ;
>  	Status = (Adapter->gpioBitMap & gpios) ^ gpios ;

You missed the space before the semicolons here.

> -	if(Status)
> +	if (Status)
>  		return FALSE;
>  	else
>  		return TRUE;

But, more importantly, why only do whitespace related stuff? Almost
every second word apparently needs to be restyled here. Is doing just
whitespace related stuff worthwhile? (This is not a rhetorical question.
I'm actually wondering what Greg prefers).


Paul Bolle