From: Pawel Moll <pawel.moll@arm.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Peter Maydell <Peter.Maydell@arm.com>
Subject: Additional virtio-mmio spec changes
Date: Tue, 01 Nov 2011 13:01:39 +0000 [thread overview]
Message-ID: <1320152499.3287.197.camel@hornet.cambridge.arm.com> (raw)
Hi Rusty,
Peter (on Cc) got the qemu implementation up and running (thanks!) and
provided some useful feedback regarding the spec. To make the long story
short, this is what came out of the discussion (feel free to correct me
at any point, Peter ;-):
diff --git a/virtio-spec.lyx b/virtio-spec.lyx
index 6426f8f..79a6498 100644
--- a/virtio-spec.lyx
+++ b/virtio-spec.lyx
@@ -6681,7 +6681,9 @@ s on QueueNum, QueueAlign and QueuePFN apply to.
Writing to this register notifies the Host what size of the queue the Guest
will use.
- This applies to the queue selected by writing to QueueSel.
+ This applies to the queue selected by writing to QueueSel and is allowed
+ only when QueuePFN is set to zero (0x0), so when the queue is not actively
+ used.
\end_layout
@@ -6790,8 +6792,8 @@ This interrupt is asserted when configuration of the device has changed.
Writing to this register notifies the Host that the Guest finished handling
interrupts.
- Every bit of the value clears corresponding bit of the InterruptStatus
- register.
+ Set bits in the value clear the corresponding bits of the
+ InterruptStatus register.
\end_layout
@@ -6975,7 +6977,9 @@ reference "sub:Notifying-The-Device"
\end_layout
\begin_layout Enumerate
-The memory mapped virtio device is using single, dedicated interrupt signal.
+The memory mapped virtio device is using single, dedicated interrupt signal,
+ which is raised when at least one of the interrupts described in the
+ InterruptStatus register description is asserted.
After receiving an interrupt, the driver must read the InterruptStatus
register to check what caused the interrupt (see the register description).
After the interrupt is handled, the driver must acknowledge it by writing
Of course those changes are not critical so can easily wait till the
next release. Peter also mentioned that he didn't like the "Num" in
"QueueNum" register name and would rather see it called "QueueSize". I
have no strong opinions either way and can provide patches to both the
spec and the driver (and header) to change it. Any thoughts?
Cheers!
Paweł
next reply other threads:[~2011-11-01 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 13:01 Pawel Moll [this message]
2011-11-02 1:21 ` Rusty Russell
2011-11-02 13:31 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320152499.3287.197.camel@hornet.cambridge.arm.com \
--to=pawel.moll@arm.com \
--cc=Peter.Maydell@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®