mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Prarit Bhargava <prarit@redhat.com>,
	tglx@linutronix.de, johnstul@us.ibm.com
Subject: [PATCH] [PATCH]: Reset clocksource watchdog after sysrq-t
Date: Wed,  2 Nov 2011 09:46:25 -0400	[thread overview]
Message-ID: <1320241585-28056-1-git-send-email-prarit@redhat.com> (raw)

When doing a sysrq-t other processes are starved out because the task_list
lock is held.  On a large enough system this means that the clocksource
watchdog does not fire for a long time and when system operation resumes the
watchdog erroneously marks the current clocksource as unstable.

Reset the clocksource watchdog after show_state_filter() has dumped the
task states.

Cc: tglx@linutronix.de
Cc: johnstul@us.ibm.com
---
 kernel/sched.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index d87c6e5..b09c053 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -71,6 +71,7 @@
 #include <linux/ctype.h>
 #include <linux/ftrace.h>
 #include <linux/slab.h>
+#include <linux/clocksource.h>
 
 #include <asm/tlb.h>
 #include <asm/irq_regs.h>
@@ -6034,6 +6035,7 @@ void show_state_filter(unsigned long state_filter)
 	} while_each_thread(g, p);
 
 	touch_all_softlockup_watchdogs();
+	clocksource_touch_watchdog();
 
 #ifdef CONFIG_SCHED_DEBUG
 	sysrq_sched_debug_show();
-- 
1.7.1


             reply	other threads:[~2011-11-02 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 13:46 Prarit Bhargava [this message]
2011-12-01  4:08 ` Xiaochen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320241585-28056-1-git-send-email-prarit@redhat.com \
    --to=prarit@redhat.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome