From: Steven Rostedt <rostedt@goodmis.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Restore system filter behavior
Date: Wed, 02 Nov 2011 14:51:08 -0400 [thread overview]
Message-ID: <1320259868.4793.46.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1320258167.4793.45.camel@gandalf.stny.rr.com>
On Wed, 2011-11-02 at 14:22 -0400, Steven Rostedt wrote:
> The above shows how things are just ambiguous. I have no problem in
> using the top filter to set multiple events. But the top filter should
> not keep the state of what was set. Perhaps just have system event
> filters always show default text. Like:
>
> # cat /debug/tracing/events/sched/filter
> ### global filter ###
> # Use this to set multiple event filters
> # Only affects events that have the event fields specified in the filter
>
>
> I'll add your patch, but are you OK with the above always printing for
> system event filters? Just to remove the ambiguous state.
As the filter is also used to show errors, I'll only have it print the
"message" if the filter worked. If there's an error, then the error
message will display instead.
-- Steve
next prev parent reply other threads:[~2011-11-02 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 1:09 Li Zefan
2011-11-02 18:22 ` Steven Rostedt
2011-11-02 18:51 ` Steven Rostedt [this message]
2011-11-02 20:45 ` Steven Rostedt
2011-11-03 1:25 ` Li Zefan
2011-11-03 1:35 ` Steven Rostedt
2011-11-18 23:05 ` [tip:perf/core] " tip-bot for Li Zefan
2011-12-06 6:26 ` tip-bot for Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320259868.4793.46.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®