mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: David Ahern <dsahern@gmail.com>
Cc: avagin@gmail.com, Andrew Vagin <avagin@openvz.org>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	devel@openvz.org, Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH] event: fix TP_printk() argument in sched_switch
Date: Thu, 03 Nov 2011 10:11:52 -0400	[thread overview]
Message-ID: <1320329512.27370.13.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <4EB29E9C.1010004@gmail.com>

On Thu, 2011-11-03 at 08:01 -0600, David Ahern wrote:
> On 11/03/2011 06:57 AM, Andrew Vagin wrote:
> > 
> >> NACK!
> >>
> >> This is a perf userspace bug, not a kernel one. Please fix the userspace
> >> tool instead.
> >>
> >> Note, the new version of libparsevent handles this case without issue.
> >> Perf just needs to be updated.
> > I don't understand. I've got
> > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git
> > and it reports the same error. Where am I wrong?
> 
> Have you installed the plugins?
> 

That's cheating ;)  Yeah, the plugins override what is printed, but this
is a trivial thing that the parsing itself should easily be able to
handle. I'm working on a fix now.

trace-cmd report -N

will fail.  That's because -N does not load the plugins.

-- Steve



  reply	other threads:[~2011-11-03 14:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 22:40 Andrew Vagin
2011-11-02 23:07 ` Steven Rostedt
2011-11-02 23:23   ` David Ahern
2011-11-03  0:13     ` Steven Rostedt
2011-11-03 12:57   ` Andrew Vagin
2011-11-03 14:01     ` David Ahern
2011-11-03 14:11       ` Steven Rostedt [this message]
2011-11-03 14:02     ` Steven Rostedt
2011-11-03 14:15     ` Steven Rostedt
2011-11-03 14:19   ` Steven Rostedt
2011-11-03 21:36     ` avagin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320329512.27370.13.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=avagin@gmail.com \
    --cc=avagin@openvz.org \
    --cc=devel@openvz.org \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®