From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: sergey.senozhatsky@gmail.com, bp@alien8.de,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: [RFC PATCH 2/4] lockdep: Let register_lock_class() can be called with/without graph_lock
Date: Fri, 4 Nov 2011 17:26:28 +0800 [thread overview]
Message-ID: <1320398790-21663-3-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1320398790-21663-1-git-send-email-yong.zhang0@gmail.com>
Will be used in later patch which fix some race condition in
lock_set_class().
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
---
kernel/lockdep.c | 14 +++++++++-----
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 4a16b0a..e7d38fa 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -711,9 +711,13 @@ look_up_lock_class(struct lockdep_map *lock, unsigned int subclass)
* Register a lock's class in the hash-table, if the class is not present
* yet. Otherwise we look it up. We cache the result in the lock object
* itself, so actual lookup of the hash should be once per lock object.
+ *
+ * NOTE: register_lock_class() can be called with/without graph_lock hold
+ * depending on @locked. But it will release graph_lock before return.
*/
static inline struct lock_class *
-register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
+register_lock_class(struct lockdep_map *lock, unsigned int subclass,
+ int force, int locked)
{
struct lockdep_subclass_key *key;
struct list_head *hash_head;
@@ -741,7 +745,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
hash_head = classhashentry(key);
raw_local_irq_save(flags);
- if (!graph_lock()) {
+ if (!locked && !graph_lock()) {
raw_local_irq_restore(flags);
return NULL;
}
@@ -2986,7 +2990,7 @@ void lockdep_init_map(struct lockdep_map *lock, const char *name,
return;
if (subclass)
- register_lock_class(lock, subclass, 1);
+ register_lock_class(lock, subclass, 1, 0);
}
EXPORT_SYMBOL_GPL(lockdep_init_map);
@@ -3032,7 +3036,7 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
* Not cached?
*/
if (unlikely(!class)) {
- class = register_lock_class(lock, subclass, 0);
+ class = register_lock_class(lock, subclass, 0, 0);
if (!class)
return 0;
}
@@ -3276,7 +3280,7 @@ found_it:
/* optimizing for lock_set_subclass() */
if (key) {
lockdep_init_map(lock, name, key, 0);
- register_lock_class(lock, subclass, 0);
+ register_lock_class(lock, subclass, 0, 0);
}
curr->lockdep_depth = i;
--
1.7.5.4
next prev parent reply other threads:[~2011-11-04 9:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 9:26 [PATCH 0/4] patches to cure race in lock_set_class() Yong Zhang
2011-11-04 9:26 ` [PATCH 1/4] lockdep: lock_set_subclass() fix Yong Zhang
2011-11-07 12:34 ` Peter Zijlstra
2011-11-07 13:31 ` Yong Zhang
2011-11-07 14:03 ` Tejun Heo
2011-11-07 13:54 ` Borislav Petkov
2011-11-07 15:28 ` Vegard Nossum
2011-11-07 16:10 ` Peter Zijlstra
2011-11-07 16:21 ` Tejun Heo
2011-11-07 16:26 ` Peter Zijlstra
2011-11-08 2:58 ` Yong Zhang
2011-11-08 3:02 ` Yong Zhang
2011-11-08 7:56 ` Peter Zijlstra
2011-11-08 8:14 ` Yong Zhang
2011-11-08 8:46 ` Peter Zijlstra
2011-11-08 9:07 ` Yong Zhang
2011-11-08 9:37 ` Yong Zhang
2011-11-08 9:40 ` Peter Zijlstra
2011-11-09 8:04 ` [PATCH 1/2] lockdep: kmemcheck: annotate ->lock in lockdep_init_map() Yong Zhang
2011-11-09 8:07 ` [PATCH 2/2] lockdep: always try to set ->class_cache in register_lock_class() lockdep_init_map() Yong Zhang
2011-11-18 23:39 ` [tip:core/locking] lockdep: Always " tip-bot for Yong Zhang
2011-12-06 9:39 ` [tip:core/locking] lockdep, kmemcheck: Annotate ->lock in lockdep_init_map() tip-bot for Yong Zhang
2011-12-06 19:56 ` David Rientjes
2011-12-06 20:14 ` [tip:perf/urgent] " tip-bot for Yong Zhang
2011-11-08 2:22 ` [PATCH 1/4] lockdep: lock_set_subclass() fix Yong Zhang
2011-11-04 9:26 ` Yong Zhang [this message]
2011-11-04 9:26 ` [RFC PATCH 3/4] lockdep: split lockdep_init_map() Yong Zhang
2011-11-04 9:26 ` [RFC PATCH 4/4] lockdep: fix race condition in __lock_set_class() Yong Zhang
2011-11-07 12:30 ` Peter Zijlstra
2011-11-07 13:26 ` Yong Zhang
2011-11-06 11:52 ` [PATCH 0/4] patches to cure race in lock_set_class() Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320398790-21663-3-git-send-email-yong.zhang0@gmail.com \
--to=yong.zhang0@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®