From: Valdis.Kletnieks@vt.edu
To: Rohit Yadav <rohityadav89@gmail.com>
Cc: len.brown@intel.com, trenn@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Arch: x86: process: Fix a compilation warning.
Date: Mon, 30 May 2011 14:11:39 -0400 [thread overview]
Message-ID: <13206.1306779099@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 30 May 2011 23:28:47 +0530." <BANLkTim2yJkQG=2JzFwxcAUfB3HF_m52Rg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
On Mon, 30 May 2011 23:28:47 +0530, Rohit Yadav said:
> Attached: New patch.
Still needs help:
> Remove unknown escape sequence \i in idle_setup.
> - WARN_ONCE(1, "\idle=mwait\" will be removed in 2012\"\n");
> + WARN_ONCE(1, "\"idle=mwait\" will be removed in 2012.\n");
Changelog should say "Fix mismatched escaped quotes to resolve compiler warning" or
similar. You should explain *what* the patch does (fix the quotes) and *why*
(because it's broken and won't compile).
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-05-30 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 17:30 Rohit Yadav
2011-05-30 17:40 ` Valdis.Kletnieks
2011-05-30 17:58 ` Rohit Yadav
2011-05-30 18:11 ` Valdis.Kletnieks [this message]
2011-05-30 18:22 ` Borislav Petkov
2011-05-30 19:52 ` Rohit Yadav
2011-05-30 20:00 ` Randy Dunlap
2011-05-30 20:21 ` Borislav Petkov
2011-05-30 20:17 ` Borislav Petkov
2011-05-30 23:22 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13206.1306779099@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rohityadav89@gmail.com \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®