Re: [PATCH] Driver for GE PIO2 VME Card

[Paul Bolle <pebolle@tiscali.nl>]

On Mon, 2011-11-07 at 09:34 +0000, Martyn Welch wrote:
> On 04/11/11 19:55, Paul Bolle wrote:
> >> +	  implementing 32 solid-state relay switched IO lines, in 4 groups of 8.
> >> +	  The IO lines are provided as input, output or both as a build time
> >> +	  option.
> > 
> > What option would that be? 
> 
> I think "Each bank of IO lines is pre-configured as input, output or both
> depending on the variant of the card" may be a bit clearer?

So this concerns a physical build option! Anything that makes that clear
(like your alternative does) is fine with me. (Perhaps "is
pre-configured" could be "functions", as that's less ambiguous in a
Kconfig file, but that's debatable.)

> > All module parameters have a sysfs visibility (or permission) of zero.
> > Why is that? (This might very well be a naive question. But I often
> > wonder why a certain parameter's permission isn't at least 400, just to
> > allow a quick check of that parameter.) Are arrays tricky in sysfs? 
> 
> Hadn't really thought about it to be honest. There seems to be plenty of
> examples where it's set to non-zero.

(Perhaps you meant to write "set to zero" here.)

Greg already explained that it's OK to leave the code as is for now
(since all these control knobs need to be provided via "real" sysfs
files in the long run anyhow).


Paul Bolle