From: Paul Bolle <pebolle@tiscali.nl>
To: Jiri Kosina <trivial@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@vger.kernel.org
Subject: [PATCH] [TRIVIAL] 8250_hp300: Fix warning typo 'CONFIG_8250'
Date: Mon, 07 Nov 2011 14:44:36 +0100 [thread overview]
Message-ID: <1320673476.14409.367.camel@x61.thuisdomein> (raw)
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) This patch is untested: I have neither the hardware nor the toolchain
needed. It should be correct (though it makes an already too long line
even longer). Nevertheless I think a proper solution is a patch that
drops this warning entirely. I've CC'd the m68k people for further
feedback.
1) If SERIAL_8250_HP300 is set but neither HPDCA nor HPAPCI are set we
end up with an elaborate nop, don't we? Initialization should always
fail in that case. So effectively SERIAL_8250_HP300 depends on HPDCA
and/or HPAPCI. Was there perhaps some problem in translating that
dependency into a Kconfig dependency?
2) Related question: is it useful to have both HPDCA and HPAPCI set?
drivers/tty/serial/8250_hp300.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/tty/serial/8250_hp300.c b/drivers/tty/serial/8250_hp300.c
index c13438c..dc41fbb 100644
--- a/drivers/tty/serial/8250_hp300.c
+++ b/drivers/tty/serial/8250_hp300.c
@@ -21,7 +21,7 @@
#include "8250.h"
#if !defined(CONFIG_HPDCA) && !defined(CONFIG_HPAPCI)
-#warning CONFIG_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
+#warning CONFIG_SERIAL_8250 defined but neither CONFIG_HPDCA nor CONFIG_HPAPCI defined, are you sure?
#endif
#ifdef CONFIG_HPAPCI
--
1.7.4.4
next reply other threads:[~2011-11-07 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 13:44 Paul Bolle [this message]
2011-11-08 9:26 ` Jiri Kosina
2011-11-08 9:34 ` Paul Bolle
2011-11-08 10:32 ` Geert Uytterhoeven
2011-11-09 19:52 ` Geert Uytterhoeven
2011-11-10 10:22 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320673476.14409.367.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®