From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933159Ab1KGRzV (ORCPT ); Mon, 7 Nov 2011 12:55:21 -0500 Received: from imr4.ericy.com ([198.24.6.9]:38732 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933071Ab1KGRzT (ORCPT ); Mon, 7 Nov 2011 12:55:19 -0500 Subject: Re: [PATCH] IIO:hwmon interface client driver. From: Guenter Roeck Reply-To: guenter.roeck@ericsson.com To: Jonathan Cameron CC: "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "khali@linux-fr.org" , "dmitry.torokhov@gmail.com" , "broonie@opensource.wolfsonmicro.com" , "gregkh@suse.de" , "alan@lxorguk.ukuu.org.uk" , "arnd@arndb.de" , "linus.walleij@linaro.org" , "lars@metafoo.de" , "maxime.ripard@free-electrons.com" , "lm-sensors@lm-sensors.org" , "thomas.petazzoni@free-electrons.com" , "zdevai@gmail.com" , Jonathan Cameron In-Reply-To: <1320687781-15306-1-git-send-email-jic23@kernel.org> References: <4EB817C6.5070503@kernel.org> <1320687781-15306-1-git-send-email-jic23@kernel.org> Content-Type: text/plain; charset="UTF-8" Organization: Ericsson Date: Mon, 7 Nov 2011 09:52:59 -0800 Message-ID: <1320688379.2309.121.camel@groeck-laptop> MIME-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, I know I must be getting annoying, but somehow it seems I just keep finding something whenever I look at the code again. On Mon, 2011-11-07 at 12:43 -0500, Jonathan Cameron wrote: > From: Jonathan Cameron > > Should move to drivers/hwmon once people are happy with it. > > Minimal support of simple in, curr and temp attributes > so far. > > Signed-off-by: Jonathan Cameron > --- > Fixed up the missing free Guenter spotted. > Thanks! > drivers/iio/Kconfig | 8 ++ > drivers/iio/Makefile | 1 + > drivers/iio/iio_hwmon.c | 228 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 237 insertions(+), 0 deletions(-) > create mode 100644 drivers/iio/iio_hwmon.c > > diff --git a/drivers/iio/Kconfig b/drivers/iio/Kconfig > index 308bc97..c2f0970 100644 > --- a/drivers/iio/Kconfig > +++ b/drivers/iio/Kconfig > @@ -11,6 +11,14 @@ menuconfig IIO > > if IIO > > +config IIO_HWMON > + tristate "Hwmon driver that uses channels specified via iio maps" > + depends on HWMON > + help > + This is a platform driver that in combination with a suitable > + map allows IIO devices to provide basic hwmon functionality > + for those channels specified in the map. > + > source "drivers/iio/adc/Kconfig" > source "drivers/iio/imu/Kconfig" > source "drivers/iio/light/Kconfig" > diff --git a/drivers/iio/Makefile b/drivers/iio/Makefile > index cfb588a..5f9c01a 100644 > --- a/drivers/iio/Makefile > +++ b/drivers/iio/Makefile > @@ -6,6 +6,7 @@ obj-y = inkern.o > obj-$(CONFIG_IIO) += iio.o > industrialio-y := core.o > > +obj-$(CONFIG_IIO_HWMON) += iio_hwmon.o > obj-y += adc/ > obj-y += imu/ > obj-y += light/ > diff --git a/drivers/iio/iio_hwmon.c b/drivers/iio/iio_hwmon.c > new file mode 100644 > index 0000000..880ce6d > --- /dev/null > +++ b/drivers/iio/iio_hwmon.c > @@ -0,0 +1,228 @@ > +/* Hwmon client for industrial I/O devices > + * > + * Copyright (c) 2011 Jonathan Cameron > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License version 2 as published by > + * the Free Software Foundation. > + * > + * Limited functionality currently supported. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/** > + * struct iio_hwmon_state - device instance state > + * @channels: filled with null terminated array of channels from iio > + * @num_channels: number of channels in channels (saves counting twice) > + * @hwmon_dev: associated hwmon device > + * @attr_group: the group of attributes > + * @attrs: null terminated array of attribute pointers. > + */ > +struct iio_hwmon_state { > + struct iio_channel **channels; > + int num_channels; > + struct device *hwmon_dev; > + struct attribute_group attr_group; > + struct attribute **attrs; > +}; > + > +/* > + * Assumes that IIO and hwmon operate in the same base units. > + * This is supposed to be true, but needs verification for > + * new channel types. > + */ > +static ssize_t iio_hwmon_read_val(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + long result; > + int val, ret, scaleint, scalepart; > + struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr); > + struct iio_hwmon_state *state = dev_get_drvdata(dev); > + > + /* > + * No locking between this pair, so theoretically possible > + * the scale has changed. > + */ > + ret = iio_read_channel_raw(state->channels[sattr->index], > + &val); > + if (ret < 0) > + return ret; > + > + ret = iio_read_channel_scale(state->channels[sattr->index], > + &scaleint, &scalepart); > + if (ret < 0) > + return ret; > + switch (ret) { > + case IIO_VAL_INT: > + result = val * scaleint; > + break; > + case IIO_VAL_INT_PLUS_MICRO: > + result = (long)val * (long)scaleint + > + div_s64((s64)val * (s64)scalepart, 1000000LL); > + break; > + case IIO_VAL_INT_PLUS_NANO: > + result = (long)val * (long)scaleint + > + div_s64((s64)val * (s64)scalepart, 1000000000LL); > + break; > + default: > + return -EINVAL; > + } > + return sprintf(buf, "%ld\n", result); > +} > + > +static void iio_hwmon_free_attrs(struct iio_hwmon_state *st) > +{ > + int i; > + struct sensor_device_attribute *a; > + for (i = 0; i < st->num_channels; i++) > + if (st->attrs[i]) { > + a = to_sensor_dev_attr( > + container_of(st->attrs[i], > + struct device_attribute, > + attr)); I finally looked into kasprintf ... which as it turns out allocates memory. Yet, there is no kfree(a->dev_attr.attr.name). Thanks, Guenter