From: Davidlohr Bueso <dave@gnu.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
Wanlong Gao <gaowanlong@cn.fujitsu.com>,
Nick Piggin <npiggin@kernel.dk>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ipc/mqueue: simplify reading msgqueue limit
Date: Mon, 07 Nov 2011 19:15:56 -0300 [thread overview]
Message-ID: <1320704156.3009.0.camel@offbook> (raw)
In-Reply-To: <1320345109.3188.3.camel@offbook>
ping?
On Thu, 2011-11-03 at 15:31 -0300, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> Because the current task is being used to get the limit, we can simply use rlimit() instead of task_rlimit().
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
> ipc/mqueue.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/ipc/mqueue.c b/ipc/mqueue.c
> index 2e0ecfc..c0e4fbb 100644
> --- a/ipc/mqueue.c
> +++ b/ipc/mqueue.c
> @@ -127,7 +127,6 @@ static struct inode *mqueue_get_inode(struct super_block *sb,
>
> if (S_ISREG(mode)) {
> struct mqueue_inode_info *info;
> - struct task_struct *p = current;
> unsigned long mq_bytes, mq_msg_tblsz;
>
> inode->i_fop = &mqueue_file_operations;
> @@ -158,7 +157,7 @@ static struct inode *mqueue_get_inode(struct super_block *sb,
>
> spin_lock(&mq_lock);
> if (u->mq_bytes + mq_bytes < u->mq_bytes ||
> - u->mq_bytes + mq_bytes > task_rlimit(p, RLIMIT_MSGQUEUE)) {
> + u->mq_bytes + mq_bytes > rlimit(RLIMIT_MSGQUEUE)) {
> spin_unlock(&mq_lock);
> /* mqueue_evict_inode() releases info->messages */
> ret = -EMFILE;
next prev parent reply other threads:[~2011-11-07 22:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 18:31 Davidlohr Bueso
2011-11-07 22:15 ` Davidlohr Bueso [this message]
2011-11-16 0:10 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320704156.3009.0.camel@offbook \
--to=dave@gnu.org \
--cc=akpm@linux-foundation.org \
--cc=gaowanlong@cn.fujitsu.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome