From: Petr Holasek <pholasek@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: anton@redhat.com, Petr Holasek <pholasek@redhat.com>,
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86
ARCHITECTURE...),
Ingo Molnar <mingo@redhat.com> (maintainer:X86 ARCHITECTURE...
,commit_signer:7/19=37%),
"H. Peter Anvin" <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...),
x86@kernel.org (maintainer:X86 ARCHITECTURE...),
Tejun Heo <tj@kernel.org> (commit_signer:15/19=79%),
Pekka Enberg <penberg@kernel.org> (commit_signer:3/19=16%),
David Rientjes <rientjes@google.com> (commit_signer:2/19=11%),
Yinghai Lu <yinghai@kernel.org> (commit_signer:2/19=11%)
Subject: [PATCH] NUMA x86: add constraints check for nid parameters in numa.c functions
Date: Tue, 8 Nov 2011 14:28:42 +0100 [thread overview]
Message-ID: <1320758922-7309-1-git-send-email-pholasek@redhat.com> (raw)
This patch adds constraints checks into __node_distance() and
numa_set_distance() functions. If from or to parameters are
lower than zero, it results into oops now.
Signed-off-by: Petr Holasek <pholasek@redhat.com>
---
arch/x86/mm/numa.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index fbeaaf4..0f98356 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -439,6 +439,12 @@ void __init numa_set_distance(int from, int to, int distance)
if (!numa_distance && numa_alloc_distance() < 0)
return;
+ if (from < 0 || to < 0) {
+ pr_warn_once("NUMA: Warning: invalid from/to nid parameter, from=%d to=%d distance=%d\n",
+ from, to, distance);
+ return;
+ }
+
if (from >= numa_distance_cnt || to >= numa_distance_cnt) {
printk_once(KERN_DEBUG "NUMA: Debug: distance out of bound, from=%d to=%d distance=%d\n",
from, to, distance);
@@ -457,7 +463,7 @@ void __init numa_set_distance(int from, int to, int distance)
int __node_distance(int from, int to)
{
- if (from >= numa_distance_cnt || to >= numa_distance_cnt)
+ if (from < 0 || to < 0 || from >= numa_distance_cnt || to >= numa_distance_cnt)
return from == to ? LOCAL_DISTANCE : REMOTE_DISTANCE;
return numa_distance[from * numa_distance_cnt + to];
}
--
1.7.6.4
reply other threads:[~2011-11-08 13:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320758922-7309-1-git-send-email-pholasek@redhat.com \
--to=pholasek@redhat.com \
--cc=anton@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®