From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
ohering@suse.com, James.Bottomley@HansenPartnership.com,
hch@infradead.org
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>
Subject: [PATCH 11/11] Staging: hv: storvsc: Support hot-removing of scsi devices
Date: Tue, 8 Nov 2011 09:01:50 -0800 [thread overview]
Message-ID: <1320771710-29139-11-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1320771710-29139-1-git-send-email-kys@microsoft.com>
Support hot-removing of scsi devices.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/staging/hv/storvsc_drv.c | 45 ++++++++++++++++++++++++++++++++++++++
1 files changed, 45 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index 7c82d14..0245143 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -328,6 +328,27 @@ static void storvsc_bus_scan(struct work_struct *work)
kfree(wrk);
}
+static void storvsc_remove_lun(struct work_struct *work)
+{
+ struct storvsc_scan_work *wrk;
+ struct scsi_device *sdev;
+
+ wrk = container_of(work, struct storvsc_scan_work, work);
+ if (!scsi_host_get(wrk->host))
+ goto done;
+
+ sdev = scsi_device_lookup(wrk->host, 0, 0, wrk->lun);
+
+ if (sdev) {
+ scsi_remove_device(sdev);
+ scsi_device_put(sdev);
+ }
+ scsi_host_put(wrk->host);
+
+done:
+ kfree(wrk);
+}
+
static inline struct storvsc_device *get_out_stor_device(
struct hv_device *device)
{
@@ -1112,6 +1133,7 @@ static void storvsc_command_completion(struct hv_storvsc_request *request)
void (*scsi_done_fn)(struct scsi_cmnd *);
struct scsi_sense_hdr sense_hdr;
struct vmscsi_request *vm_srb;
+ struct storvsc_scan_work *wrk;
vm_srb = &request->vstor_packet.vm_srb;
if (cmd_request->bounce_sgl_count) {
@@ -1134,6 +1156,29 @@ static void storvsc_command_completion(struct hv_storvsc_request *request)
else
scmnd->result = vm_srb->scsi_status;
+ /*
+ * If the LUN is invalid; remove the device.
+ */
+ if (vm_srb->srb_status == 0x20) {
+ struct storvsc_device *stor_dev;
+ struct hv_device *dev = host_dev->dev;
+ struct Scsi_Host *host;
+
+ stor_dev = get_in_stor_device(dev);
+ host = stor_dev->host;
+
+ wrk = kmalloc(sizeof(struct storvsc_scan_work),
+ GFP_ATOMIC);
+ if (!wrk) {
+ scmnd->result = DID_TARGET_FAILURE << 16;
+ } else {
+ wrk->host = host;
+ wrk->lun = vm_srb->lun;
+ INIT_WORK(&wrk->work, storvsc_remove_lun);
+ schedule_work(&wrk->work);
+ }
+ }
+
if (scmnd->result) {
if (scsi_normalize_sense(scmnd->sense_buffer,
SCSI_SENSE_BUFFERSIZE, &sense_hdr))
--
1.7.4.1
prev parent reply other threads:[~2011-11-08 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 17:01 [PATCH 0000/0011] Staging: hv: storvsc cleanup/new features K. Y. Srinivasan
2011-11-08 16:39 ` James Bottomley
2011-11-08 16:46 ` KY Srinivasan
2011-11-08 17:01 ` [PATCH 01/11] Staging: hv: storvsc: Use mempools to allocate struct storvsc_cmd_request K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 02/11] Staging: hv: storvsc: Cleanup error handling in the probe function K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 03/11] Staging: hv: storvsc: Fixup the error when processing SET_WINDOW command K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 04/11] Staging: hv: storvsc: Fix error handling storvsc_host_reset() K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 05/11] Staging: hv: storvsc: Use the accessor function shost_priv() K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 06/11] Staging: hv: storvsc: Use the unlocked version queuecommand K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 07/11] Staging: hv: storvsc: use the macro KBUILD_MODNAME K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 08/11] Staging: hv: storvsc: Get rid of an unnecessary forward declaration K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 09/11] Staging: hv: storvsc: Upgrade the vmstor protocol version K. Y. Srinivasan
2011-11-08 17:01 ` [PATCH 10/11] Staging: hv: storvsc: Support hot add of scsi disks K. Y. Srinivasan
2011-11-08 17:01 ` K. Y. Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320771710-29139-11-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohering@suse.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®