mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: devicetree-discuss@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	Sascha Hauer <kernel@pengutronix.de>,
	Rob Herring <rob.herring@calxeda.com>
Cc: linux-kernel@vger.kernel.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Michal Simek <monstr@monstr.eu>
Subject: [RFC 1/8] gpio/microblaze: Eliminate duplication of of_get_named_gpio_flags()
Date: Tue,  8 Nov 2011 18:19:36 -0700	[thread overview]
Message-ID: <1320801583-12774-2-git-send-email-grant.likely@secretlab.ca> (raw)
In-Reply-To: <1320801583-12774-1-git-send-email-grant.likely@secretlab.ca>

of_reset_gpio_handle() is largely a cut-and-paste copy of
of_get_named_gpio_flags(). There really isn't any reason for the
split, so this patch deletes the duplicate function

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Cc: Michal Simek <monstr@monstr.eu>
---
 arch/microblaze/kernel/reset.c |   43 +--------------------------------------
 1 files changed, 2 insertions(+), 41 deletions(-)

diff --git a/arch/microblaze/kernel/reset.c b/arch/microblaze/kernel/reset.c
index bd8ccab..88a0163 100644
--- a/arch/microblaze/kernel/reset.c
+++ b/arch/microblaze/kernel/reset.c
@@ -19,50 +19,11 @@
 static int handle; /* reset pin handle */
 static unsigned int reset_val;
 
-static int of_reset_gpio_handle(void)
-{
-	int ret; /* variable which stored handle reset gpio pin */
-	struct device_node *root; /* root node */
-	struct device_node *gpio; /* gpio node */
-	struct gpio_chip *gc;
-	u32 flags;
-	const void *gpio_spec;
-
-	/* find out root node */
-	root = of_find_node_by_path("/");
-
-	/* give me handle for gpio node to be possible allocate pin */
-	ret = of_parse_phandles_with_args(root, "hard-reset-gpios",
-				"#gpio-cells", 0, &gpio, &gpio_spec);
-	if (ret) {
-		pr_debug("%s: can't parse gpios property\n", __func__);
-		goto err0;
-	}
-
-	gc = of_node_to_gpiochip(gpio);
-	if (!gc) {
-		pr_debug("%s: gpio controller %s isn't registered\n",
-			 root->full_name, gpio->full_name);
-		ret = -ENODEV;
-		goto err1;
-	}
-
-	ret = gc->of_xlate(gc, root, gpio_spec, &flags);
-	if (ret < 0)
-		goto err1;
-
-	ret += gc->base;
-err1:
-	of_node_put(gpio);
-err0:
-	pr_debug("%s exited with status %d\n", __func__, ret);
-	return ret;
-}
-
 void of_platform_reset_gpio_probe(void)
 {
 	int ret;
-	handle = of_reset_gpio_handle();
+	handle = of_get_named_gpio(of_find_node_by_path("/"),
+				   "hard-reset-gpios", 0);
 
 	if (!gpio_is_valid(handle)) {
 		printk(KERN_INFO "Skipping unavailable RESET gpio %d (%s)\n",
-- 
1.7.5.4


  reply	other threads:[~2011-11-09  1:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09  1:19 [RFC 0/8] Initial DT clock bindings Grant Likely
2011-11-09  1:19 ` Grant Likely [this message]
2011-12-21 10:22   ` [RFC 1/8] gpio/microblaze: Eliminate duplication of of_get_named_gpio_flags() Michal Simek
2012-01-04 18:30     ` Grant Likely
2012-01-05  7:28       ` Michal Simek
2011-11-09  1:19 ` [RFC 2/8] gpio/powerpc: " Grant Likely
2011-11-09  1:19 ` [RFC 3/8] of: create of_phandle_args to simplify return of phandle parsing data Grant Likely
2011-11-14  3:59   ` Shawn Guo
2011-11-16 18:47     ` Grant Likely
2011-11-21 15:50   ` Shawn Guo
2011-11-09  1:19 ` [RFC 4/8] of: Add device tree selftests Grant Likely
2011-11-09  1:19 ` [RFC 5/8] of: Add of_property_match_string() to find index into a string list Grant Likely
2011-11-09  1:19 ` [RFC 6/8] of: add clock providers Grant Likely
2011-11-09  2:49   ` Rob Herring
2011-11-14  2:14     ` Richard Zhao
2011-11-16 19:06       ` Grant Likely
2011-11-09  9:13   ` Sascha Hauer
2011-11-09 11:23     ` Cousson, Benoit
2011-11-09 11:49       ` Sascha Hauer
2011-11-11 19:57         ` Cousson, Benoit
2011-11-16 22:12           ` Grant Likely
2011-11-18  7:48             ` Sascha Hauer
2011-11-09 13:59       ` Rob Herring
2011-11-11 19:50         ` Cousson, Benoit
2011-11-09 13:31     ` Rob Herring
2011-11-09 18:39   ` Tony Lindgren
2011-11-21 15:37   ` Shawn Guo
2011-11-30 19:38     ` Grant Likely
2011-12-01  6:34       ` Shawn Guo
2011-11-09  1:19 ` [RFC 7/8] arm/clkdev: lookup clocks from OF " Grant Likely
2011-11-09  2:36   ` Rob Herring
2011-11-16 18:54     ` Grant Likely
2011-11-09  1:19 ` [RFC 8/8] dt/arm: versatile add clock parsing Grant Likely
2011-11-09  9:31   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320801583-12774-2-git-send-email-grant.likely@secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®