From: "Niklas Söderlund" <niklas.soderlund@ericsson.com>
To: <dougthompson@xmission.com>, <borislav.petkov@amd.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund@ericsson.com>
Subject: [PATCH] amd64_edac: fix size decoding error on K8
Date: Wed, 9 Nov 2011 15:32:58 +0100 [thread overview]
Message-ID: <1320849178-23340-1-git-send-email-niklas.soderlund@ericsson.com> (raw)
Use a lookup table to calculate the size of a chip select. The old
method of calculating size return erroneous values for some memory
configurations. The lookup table is transcribed from "DRAM CS
Address Mapping Register" [1], pages 88-89.
[1] BIOS and Kernel Developer's Guide for the AMD Athlon 64 and AMD
Opteron Processors - Revision 3.30 - doc #26094 - February 2006
http://support.amd.com/us/Processor_TechDocs/26094.pdf
Signed-off-by: Niklas Söderlund <niklas.soderlund@ericsson.com>
---
drivers/edac/amd64_edac.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 9a8bebc..396ea76 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -1108,6 +1108,10 @@ static int ddr2_cs_size(unsigned i, bool dct_width)
static int k8_dbam_to_chip_select(struct amd64_pvt *pvt, u8 dct,
unsigned cs_mode)
{
+ static const int rev_de_lookup[] = { 32, 64, 128, 128, 256, 512, 256,
+ 512, 1024, 1024, 2048 };
+
+
u32 dclr = dct ? pvt->dclr1 : pvt->dclr0;
if (pvt->ext_model >= K8_REV_F) {
@@ -1116,11 +1120,7 @@ static int k8_dbam_to_chip_select(struct amd64_pvt *pvt, u8 dct,
}
else if (pvt->ext_model >= K8_REV_D) {
WARN_ON(cs_mode > 10);
-
- if (cs_mode == 3 || cs_mode == 8)
- return 32 << (cs_mode - 1);
- else
- return 32 << cs_mode;
+ return rev_de_lookup[cs_mode];
}
else {
WARN_ON(cs_mode > 6);
--
1.7.7.1
next reply other threads:[~2011-11-09 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 14:32 Niklas Söderlund [this message]
2011-11-09 14:42 ` Borislav Petkov
2011-11-09 15:13 ` Niklas Söderlund
2011-11-09 20:35 ` Borislav Petkov
2011-11-09 20:50 ` Tony Luck
2011-11-09 21:00 ` Borislav Petkov
2011-11-14 16:54 ` [PATCH] amd64_edac: Fix K8 revD and later chip select sizes Borislav Petkov
2011-11-15 8:10 ` Niklas Söderlund
2011-11-09 20:51 ` [PATCH] amd64_edac: fix size decoding error on K8 Nils Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320849178-23340-1-git-send-email-niklas.soderlund@ericsson.com \
--to=niklas.soderlund@ericsson.com \
--cc=borislav.petkov@amd.com \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome