From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755787Ab1KIRoY (ORCPT ); Wed, 9 Nov 2011 12:44:24 -0500 Received: from imr4.ericy.com ([198.24.6.9]:49214 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709Ab1KIRoX (ORCPT ); Wed, 9 Nov 2011 12:44:23 -0500 Subject: Re: [PATCH] hwmon: lm63: Add support for the NatSemi LM96163. From: Guenter Roeck Reply-To: guenter.roeck@ericsson.com To: Thierry Reding CC: Jean Delvare , "lm-sensors@lm-sensors.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <20111108073052.GC27841@avionic-0098.mockup.avionic-design.de> References: <1320661258-1775-1-git-send-email-thierry.reding@avionic-design.de> <1320684566.2309.115.camel@groeck-laptop> <20111108073052.GC27841@avionic-0098.mockup.avionic-design.de> Content-Type: text/plain; charset="UTF-8" Organization: Ericsson Date: Wed, 9 Nov 2011 09:42:16 -0800 Message-ID: <1320860536.2309.173.camel@groeck-laptop> MIME-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-11-08 at 02:30 -0500, Thierry Reding wrote: > * Guenter Roeck wrote: > > Hi, > > > > On Mon, 2011-11-07 at 05:20 -0500, Thierry Reding wrote: > > > Signed-off-by: Thierry Reding > > > --- > > > drivers/hwmon/lm63.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c > > > index 508cb29..94e373c 100644 > > > --- a/drivers/hwmon/lm63.c > > > +++ b/drivers/hwmon/lm63.c > > > @@ -483,7 +483,7 @@ static int lm63_detect(struct i2c_client *new_client, > > > return -ENODEV; > > > } > > > > > > - if (chip_id == 0x41 && address == 0x4c) > > > + if ((chip_id == 0x41 || chip_id == 0x49) && address == 0x4c) > > > strlcpy(info->type, "lm63", I2C_NAME_SIZE); > > > else if (chip_id == 0x51 && (address == 0x18 || address == 0x4e)) > > > strlcpy(info->type, "lm64", I2C_NAME_SIZE); > > > > Minor - the new chip should be mentioned in drivers/hwmon/Kconfig and in > > Documentation/hwmon/lm63. > > I don't see how to list this variant meaningfully in the documentation. > Since, as you mention, no functionality specific to the LM96163 is added, > this patch really only adds support for one more lm63 chip. > > > My main concern is that LM96163 supports a high resolution PWM mode. > > Since that mode is much more convenient than the LM63-compatible mode, I > > think it is likely to be enabled in designs using LM96163, and it should > > be supported by the driver if we add support for LM96163. > > Unfortunately our design doesn't use the PWM at all. It is only used for > temperature measurements, so I'm not able to test any of the PWM code. I requested samples for both LM63 and LM96163, so I should be able to test that part. Guenter