From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610Ab1KJSpb (ORCPT ); Thu, 10 Nov 2011 13:45:31 -0500 Received: from www17.your-server.de ([213.133.104.17]:42853 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932429Ab1KJSp1 (ORCPT ); Thu, 10 Nov 2011 13:45:27 -0500 Message-ID: <1320950721.20155.111.camel@localhost.localdomain> Subject: [PATCH] ceph: Use kmemdup rather than duplicating its implementation From: Thomas Meyer To: Sage Weil , "David S. Miller" , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 10 Nov 2011 19:45:21 +0100 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1 (3.2.1-2.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Authenticated-Sender: thomas@m3y3r.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use kmemdup rather than duplicating its implementation The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Thomas Meyer --- diff -u -p a/net/ceph/crypto.c b/net/ceph/crypto.c --- a/net/ceph/crypto.c 2011-11-07 19:38:30.130592543 +0100 +++ b/net/ceph/crypto.c 2011-11-08 10:58:06.915274800 +0100 @@ -15,10 +15,9 @@ int ceph_crypto_key_clone(struct ceph_cr const struct ceph_crypto_key *src) { memcpy(dst, src, sizeof(struct ceph_crypto_key)); - dst->key = kmalloc(src->len, GFP_NOFS); + dst->key = kmemdup(src->key, src->len, GFP_NOFS); if (!dst->key) return -ENOMEM; - memcpy(dst->key, src->key, src->len); return 0; }