From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751310AbdFCSeg (ORCPT ); Sat, 3 Jun 2017 14:34:36 -0400 Received: from mout.web.de ([212.227.15.14]:57093 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbdFCSee (ORCPT ); Sat, 3 Jun 2017 14:34:34 -0400 Subject: [PATCH 8/9] ARM: OMAP2+: SmartReflex: Delete an error message for a failed memory allocation in two functions From: SF Markus Elfring To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , Tony Lindgren Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <13210fb0-3a22-07f5-0bc5-b338b1ccfdeb@users.sourceforge.net> Date: Sat, 3 Jun 2017 20:34:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:yr8ybQvGRRhWZKIsgU+oZEC8fAtwhsl8bwyOkhzo7dFeKz8zunE kfzYuXKRklSxYS9P6+1AuthoruCJDR9ah4up16pW1ADxh4B65ndmVNw+xDzYpPi+IdG/jtp fRTb2cn5LRGYhzLVIL3+Lwpb3Lq9hoTiK4hYSzIaKNBK9Jw9xuQQjEZTIuzJlTt3rhYcvwg IPB4ou4POV/cl9hdPkZcg== X-UI-Out-Filterresults: notjunk:1;V01:K0:k02NqdAQVYs=:OMUzduL1NRiDWlS0QAazMv CCJt4LRtt9joIlW42uFp4d/uGNWwobmii/ySQ4kUukTcENpRtymXTPH/LVtF/VzBtZopo9iu7 2LxzOnoG05f5yp7D5Xf+0VVBETBPn7ZLuP5D5R9FGvyxupM6Y5a+doK8aLOpFLWwq2VBOxDd0 lvgP0ZRxHG6yagVWK5Cqt1SAqyxq6N9pbla+R/iSPy/GhuSHpeaBZibAOjHQyE9ax7J2u0wjL Q3trOMdYcLNQSDHJfJH43iefivgzaZFaYiEAQg3sdGWkfM/guk5e71o3WVlwTxNxAtSurdH/t PNZEinEVLoZEsG29WS7TESzdWTohCTG9UoFRGm0UCwiiMDxJ4ZWo+hEp2cdG3CrZY8wcgNmQA k7e0fQ/NgTyGRyUnlFZOV3BnDehK1BkTFBD1fX/quG51dh5Cbn48tQesfSRaoknLkF1yt/+bN tIeLCMLiKqfLGdPi9Ld+0NU1IjGS/h46H1MmuyQog5VZCd+JW7ObdB+sa6YLsDhvEgqJlr+xW IQZ7ySMDGzlhIwFMN8h2LuD2YrJnB22uAaUerBggUCx/Kc7XCs0IEG4/Z13NTGvpOZ9Y8mSwn kujHDhWY3vvU6nZnjy3SKxmqin8BGs1slIlvBGyEgoppQ36iEengqlC7DWr83zUyt3H2MS5wx IUOU4/Q8ehrslQWGZbiINGldPJjEkhC44VEB7Vl1DhfFb2T8HsAe+4g7rJLYrK80xLxdiDaZk 9TPqKz1KGUOkkckE1OSeXYWM9vgU2QPiGGZQNhnjTVahnRZIOsq5YzE0BpJGxtPh3h3b2+qc8 nfekIgi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 3 Jun 2017 19:16:27 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/arm/mach-omap2/sr_device.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c index 65775c6e8c27..eef6935e0403 100644 --- a/arch/arm/mach-omap2/sr_device.c +++ b/arch/arm/mach-omap2/sr_device.c @@ -48,7 +48,5 @@ static void __init sr_set_nvalues(struct omap_volt_data *volt_data, - if (!nvalue_table) { - pr_err("OMAP: SmartReflex: cannot allocate memory for n-value table\n"); + if (!nvalue_table) return; - } for (i = 0, j = 0; i < count; i++) { u32 v; @@ -104,8 +102,5 @@ static int __init sr_dev_init(struct omap_hwmod *oh, void *user) - if (!sr_data) { - pr_err("%s: Unable to allocate memory for %s sr_data\n", - __func__, oh->name); + if (!sr_data) return -ENOMEM; - } sr_dev_attr = (struct omap_smartreflex_dev_attr *)oh->dev_attr; if (!sr_dev_attr || !sr_dev_attr->sensor_voltdm_name) { -- 2.13.0