From: Guan Xuetao <gxt@mprc.pku.edu.cn>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Jiri Kosina <trivial@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [TRIVIAL] unicore32: Fix typo 'PUV3_I2C'
Date: Mon, 14 Nov 2011 11:30:59 +0800 [thread overview]
Message-ID: <1321241459.1867.16.camel@epip-laptop> (raw)
In-Reply-To: <1321145003.20271.36.camel@x61.thuisdomein>
On Sun, 2011-11-13 at 01:43 +0100, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Guan Xuetao <gxt@mprc.pku.edu.cn>
Thanks Paul, and I have pushed this patch into my repo.
Guan Xuetao
> ---
> 0) This corrects an obvious typo. It is untested.
>
> 1) This could influence the code generated for "I2C Battery BQ27200
> Support" and for "I2C EEPROMs AT24 support". So I've CC'd the people
> involved in commit fa7499ef77 ("unicore32 machine related files: core
> files"), which introduced this typo, to actually test this.
>
> arch/unicore32/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index e57dcce..942ed61 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -237,13 +237,13 @@ menu "PKUnity NetBook-0916 Features"
>
> config I2C_BATTERY_BQ27200
> tristate "I2C Battery BQ27200 Support"
> - select PUV3_I2C
> + select I2C_PUV3
> select POWER_SUPPLY
> select BATTERY_BQ27x00
>
> config I2C_EEPROM_AT24
> tristate "I2C EEPROMs AT24 support"
> - select PUV3_I2C
> + select I2C_PUV3
> select MISC_DEVICES
> select EEPROM_AT24
>
prev parent reply other threads:[~2011-11-14 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 0:43 Paul Bolle
2011-11-14 3:30 ` Guan Xuetao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321241459.1867.16.camel@epip-laptop \
--to=gxt@mprc.pku.edu.cn \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®