mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Greg KH <greg@kroah.com>
Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
	usb-storage@lists.one-eyed-alien.net,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Felipe Balbi <balbi@ti.com>
Subject: [PATCH 10/13] usb: storagE: realtek_cr: fix sparse warnings
Date: Tue, 15 Nov 2011 09:53:37 +0200	[thread overview]
Message-ID: <1321343620-10794-11-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1321343620-10794-1-git-send-email-balbi@ti.com>

Fix the following sparse warnings:

| drivers/usb/storage/realtek_cr.c:821:6: warning: symbol
|	'rts51x_invoke_transport' was not declared. Should
|	it be static?
|
| drivers/usb/storage/realtek_cr.c:980:5: warning: symbol
|	'realtek_cr_suspend' was not declared. Should it
|	be static?
|
| drivers/usb/storage/realtek_cr.c:518:23: warning: cast
|	truncates bits from constant value (fe47 becomes 47)

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/storage/realtek_cr.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
index 0ce5f79..30f64bf 100644
--- a/drivers/usb/storage/realtek_cr.c
+++ b/drivers/usb/storage/realtek_cr.c
@@ -507,15 +507,14 @@ static int enable_oscillator(struct us_data *us)
 static int __do_config_autodelink(struct us_data *us, u8 *data, u16 len)
 {
 	int retval;
-	u16 addr = 0xFE47;
 	u8 cmnd[12] = {0};
 
-	US_DEBUGP("%s, addr = 0x%x, len = %d\n", __FUNCTION__, addr, len);
+	US_DEBUGP("%s, addr = 0xfe47, len = %d\n", __FUNCTION__, len);
 
 	cmnd[0] = 0xF0;
 	cmnd[1] = 0x0E;
-	cmnd[2] = (u8)(addr >> 8);
-	cmnd[3] = (u8)addr;
+	cmnd[2] = 0xfe;
+	cmnd[3] = 0x47;
 	cmnd[4] = (u8)(len >> 8);
 	cmnd[5] = (u8)len;
 
@@ -818,7 +817,7 @@ static inline int working_scsi(struct scsi_cmnd *srb)
 	return 1;
 }
 
-void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)
+static void rts51x_invoke_transport(struct scsi_cmnd *srb, struct us_data *us)
 {
 	struct rts51x_chip *chip = (struct rts51x_chip *)(us->extra);
 	static int card_first_show = 1;
@@ -977,7 +976,7 @@ static void realtek_cr_destructor(void *extra)
 }
 
 #ifdef CONFIG_PM
-int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message)
+static int realtek_cr_suspend(struct usb_interface *iface, pm_message_t message)
 {
 	struct us_data *us = usb_get_intfdata(iface);
 
-- 
1.7.8.rc0


  parent reply	other threads:[~2011-11-15  7:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  7:53 [PATCH 00/13] Sparse fixes Felipe Balbi
2011-11-15  7:53 ` [PATCH 01/13] usb: storage: alauda: fix sparse warnings Felipe Balbi
2011-11-15  7:53 ` [PATCH 02/13] usb: storage: cypress: fix sparse warning Felipe Balbi
2011-11-15  7:53 ` [PATCH 03/13] usb: storage: datafab: " Felipe Balbi
2011-11-15  7:53 ` [PATCH 04/13] usb: storage: ene_ub6250: fix sparse warnings Felipe Balbi
2011-11-15  7:53 ` [PATCH 05/13] usb: storage: freecom: fix sparse warning Felipe Balbi
2011-11-15  7:53 ` [PATCH 06/13] usb: storage: isd200: " Felipe Balbi
2011-11-15  7:53 ` [PATCH 07/13] usb: storage: jumpshot: " Felipe Balbi
2011-11-15  7:53 ` [PATCH 08/13] usb: storage: karma: " Felipe Balbi
2011-11-15  7:53 ` [PATCH 09/13] usb: storage: onetouch: " Felipe Balbi
2011-11-15  7:53 ` Felipe Balbi [this message]
2011-11-15  7:53 ` [PATCH 11/13] usb: storage: sddr09: " Felipe Balbi
2011-11-15  7:53 ` [PATCH 12/13] usb: storage: sddr55: " Felipe Balbi
2011-11-15  7:53 ` [PATCH 13/13] usb: storage: shuttle_usbat: " Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321343620-10794-11-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®