mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux ARM Kernel Mailing List 
	<linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Felipe Balbi <balbi@ti.com>
Subject: [PATCH/RESEND #3 6/7] arm: omap: smartreflex: fix IRQ handling bug
Date: Tue, 15 Nov 2011 10:46:04 +0200	[thread overview]
Message-ID: <1321346765-16633-7-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1321346765-16633-1-git-send-email-balbi@ti.com>

fix a bug which has been on this driver since
it was added by the original commit 984aa6db
which would never clear IRQSTATUS bits.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/mach-omap2/smartreflex.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
index eb88b36..a5399df 100644
--- a/arch/arm/mach-omap2/smartreflex.c
+++ b/arch/arm/mach-omap2/smartreflex.c
@@ -156,7 +156,7 @@ static irqreturn_t sr_interrupt(int irq, void *data)
 		break;
 	case SR_TYPE_V2:
 		/* Read the status bits */
-		sr_read_reg(sr_info, IRQSTATUS);
+		status = sr_read_reg(sr_info, IRQSTATUS);
 
 		/* Clear them by writing back */
 		sr_write_reg(sr_info, IRQSTATUS, status);
-- 
1.7.8.rc0


  parent reply	other threads:[~2011-11-15  8:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  8:45 [PATCH/RESEND #3 0/7] SmartReflex Patches Felipe Balbi
2011-11-15  8:45 ` [PATCH/RESEND #3 1/7] OMAP3+: PM: SR: add suspend/resume handlers Felipe Balbi
     [not found]   ` <87vcqj62gd.fsf@ti.com>
2011-11-19  0:35     ` Menon, Nishanth
2011-11-23 20:01       ` Kevin Hilman
2011-11-15  8:46 ` [PATCH/RESEND #3 2/7] arm: omap: smartreflex: add missing platform_set_drvdata() Felipe Balbi
2011-11-15  8:46 ` [PATCH/RESEND #3 3/7] arm: omap: smartreflex: use dev_get_drvdata() Felipe Balbi
2011-11-15  8:46 ` [PATCH/RESEND #3 4/7] arm: omap: smartreflex: move late_initcall() closer to its argument Felipe Balbi
2011-11-15  8:46 ` [PATCH/RESEND #3 5/7] arm: omap: smartreflex: clean ups all over Felipe Balbi
2011-11-16  0:39   ` Valdis.Kletnieks
2011-11-16 10:09     ` Felipe Balbi
2011-11-15  8:46 ` Felipe Balbi [this message]
2011-11-17  0:06   ` [PATCH/RESEND #3 6/7] arm: omap: smartreflex: fix IRQ handling bug Kevin Hilman
2011-11-17  7:08     ` Felipe Balbi
2011-11-15  8:46 ` [PATCH/RESEND #3 7/7] arm: omap: smartreflex: micro-optimization for sanity check Felipe Balbi
2011-11-17  0:09 ` [PATCH/RESEND #3 0/7] SmartReflex Patches Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321346765-16633-7-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®