From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C313C76196 for ; Tue, 28 Mar 2023 13:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbjC1N7e (ORCPT ); Tue, 28 Mar 2023 09:59:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232887AbjC1N7U (ORCPT ); Tue, 28 Mar 2023 09:59:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 214E519C for ; Tue, 28 Mar 2023 06:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680011913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r/qQMzMODq2NJQFTscBdpgqP90R/mKK82eNeMCBGbBc=; b=HmynSuVY23g4MP4Xt+DZfnKnLDuJ0tiNdpoU4gMaYyd/WCGy8OWsnvB3SumuyE13wb4lOU qEUk4GIjlodoop1wPq1RW7DW9YluEiyOxvxDIgfHfXAB2zWiyG8hQQexOe7Ok2zAYmgFFj w6GT7MIC9zQtqTd2i93pPLI7HO04kb4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-411-88GSLgrJOO-ZtuAQA0V4cw-1; Tue, 28 Mar 2023 09:58:30 -0400 X-MC-Unique: 88GSLgrJOO-ZtuAQA0V4cw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 91F44185A78F; Tue, 28 Mar 2023 13:58:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9AC3492C14; Tue, 28 Mar 2023 13:58:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230111052515.53941-3-zhujia.zj@bytedance.com> References: <20230111052515.53941-3-zhujia.zj@bytedance.com> <20230111052515.53941-1-zhujia.zj@bytedance.com> To: Jia Zhu Cc: dhowells@redhat.com, linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jingbo Xu Subject: Re: [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <132136.1680011908.1@warthog.procyon.org.uk> Date: Tue, 28 Mar 2023 14:58:28 +0100 Message-ID: <132137.1680011908@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jia Zhu wrote: > @@ -65,10 +71,7 @@ struct cachefiles_object { > enum cachefiles_content content_info:8; /* Info about content presence */ > unsigned long flags; > #define CACHEFILES_OBJECT_USING_TMPFILE 0 /* Have an unlinked tmpfile */ > -#ifdef CONFIG_CACHEFILES_ONDEMAND > - int ondemand_id; > - enum cachefiles_object_state state; > -#endif > + struct cachefiles_ondemand_info *private; Why is this no longer inside "#ifdef CONFIG_CACHEFILES_ONDEMAND"? Also, please don't call it "private", but rather something like "ondemand" or "ondemand_info". David