From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141Ab1KQVe4 (ORCPT ); Thu, 17 Nov 2011 16:34:56 -0500 Received: from smtp-out1.tiscali.nl ([195.241.79.176]:50683 "EHLO smtp-out1.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752955Ab1KQVey (ORCPT ); Thu, 17 Nov 2011 16:34:54 -0500 Subject: Re: [PATCH] m68k: Remove references to obsolete CONFIG_SERIAL167 From: Paul Bolle To: Geert Uytterhoeven Cc: linux-m68k@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jiri Kosina In-Reply-To: References: <1321180296-22543-1-git-send-email-geert@linux-m68k.org> <1321182176.20271.43.camel@x61.thuisdomein> <1321559636.20271.287.camel@x61.thuisdomein> Content-Type: text/plain; charset="UTF-8" Date: Thu, 17 Nov 2011 22:34:47 +0100 Message-ID: <1321565687.20271.309.camel@x61.thuisdomein> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-11-17 at 22:05 +0100, Geert Uytterhoeven wrote: > > Why do you care about SERIAL_CONSOLE? If it's only really used by > > AMIGA_BUILTIN_SERIAL why shouldn't we rename it to > > AMIGA_BUILTIN_SERIAL_CONSOLE? > > Because SERIAL_CONSOLE is a universal platform-independent symbol. > Other arches have it as well (but less than in the past). > > As soon as m68k gets a new serial driver, it will be used by 2 drivers again. If one does $ git grep -n "\<\(CONFIG_\)\?SERIAL_CONSOLE\>" | grep -v defconfig one gets a few hits (summarized): - arch/m68k/Kconfig.devices: discussed here; - arch/sparc/Kconfig: apparently unused, and can be dropped; - arch/xtensa/Kconfig and arch/xtensa/platforms/iss/console.c: the only other current usage (note that the "S6105" platform, mentioned in the Kconfig file, seems not to use it); - drivers/staging/serial/68360serial.c: uses CONFIG_SERIAL_CONSOLE, but I don't see how it can actually be set for that driver; - drivers/tty/amiserial.c: discussed here. I see nothing universal about it: two independent usages, one in */iss/console.c and one in */amiserial.c. So I'd say these can be renamed to (say) ISS_SERIAL_CONSOLE and AMIGA_BUILTIN_SERIAL_CONSOLE. Paul Bolle