mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: annie li <annie.li@oracle.com>
Cc: "jeremy@goop.org" <jeremy@goop.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [Xen-devel] [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture
Date: Fri, 18 Nov 2011 16:04:31 +0000	[thread overview]
Message-ID: <1321632271.3664.367.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <4EC6818B.3010904@oracle.com>


> > > +static struct gnttab_ops gnttab_v1_ops = {
> > > +       .map_frames                     = gnttab_map_frames_v1,
> > > +       .unmap_frames                   = gnttab_unmap_frames_v1,
> > > +       .update_entry                   = update_grant_entry_v1,
> > >     
> > 
> > Any reason this one is not gnttab_foo?
> >   
> Actually no, just keep the original name of this function. I'd like to
> change it, maybe gnttab_update_entry_v1 is better?

I think so. Similarly for the v2 variant.

Ian.



  parent reply	other threads:[~2011-11-18 16:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4EC3B62F.6080702@oracle.com>
2011-11-16 13:23 ` [Xen-devel] Improved patches of upstreaming grant table version 2 annie li
2011-11-16 13:48 ` [PATCH 1/3] xen/granttable: Introducing grant table V2 stucture annie.li
2011-11-17 10:35   ` Ian Campbell
     [not found]     ` <4EC53119.7060307@oracle.com>
2011-11-17 16:29       ` Konrad Rzeszutek Wilk
2011-11-18  3:08         ` [Xen-devel] " ANNIE LI
2011-11-17 16:55       ` Ian Campbell
2011-11-18 10:07   ` [Xen-devel] " ANNIE LI
2011-11-18 10:54     ` Ian Campbell
     [not found]       ` <4EC6818B.3010904@oracle.com>
2011-11-18 16:04         ` Ian Campbell [this message]
2011-11-21  9:51           ` ANNIE LI
2011-11-21 10:36             ` Ian Campbell
2011-11-16 13:49 ` [PATCH 2/3] xen/granttable: Grant tables V2 implementation annie.li
2011-11-18 10:13   ` ANNIE LI
2011-11-18 11:02     ` Ian Campbell
2011-11-18 13:52       ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-11-18 14:00         ` Ian Campbell
2011-11-18 16:10           ` annie li
2011-11-18 18:05             ` Konrad Rzeszutek Wilk
2011-11-19  3:36               ` annie li
2011-11-21  9:51               ` ANNIE LI
2011-11-21 10:35                 ` Ian Campbell
2011-11-21 11:42                   ` annie li
2011-11-16 13:50 ` [PATCH 3/3] xen/granttable: Keep code format clean annie.li
2011-11-18 10:16   ` ANNIE LI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321632271.3664.367.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=Paul.Durrant@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=jeremy@goop.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®