From: Johannes Berg <johannes@sipsolutions.net>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2] printk: add console output tracing
Date: Fri, 18 Nov 2011 19:46:15 +0100 [thread overview]
Message-ID: <1321641975.10266.73.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20111118184401.GA24787@somewhere.redhat.com> (sfid-20111118_194444_693542_8E85EDDA)
On Fri, 2011-11-18 at 19:44 +0100, Frederic Weisbecker wrote:
> > +TRACE_EVENT_CONDITION(console,
> > + TP_PROTO(const char *log_buf, unsigned start, unsigned end,
> > + unsigned log_buf_len),
> > +
> > + TP_ARGS(log_buf, start, end, log_buf_len),
> > +
> > + TP_CONDITION(start != end),
> > +
> > + TP_STRUCT__entry(
> > + __dynamic_array(char, msg,
> > + ((end - start + log_buf_len) &
> > + (log_buf_len - 1)) + 1)
>
> Is all that care about log_buf_len necessary? It seems that
> printk ensures that log_end - con_start never exceeds log_buf_len,
> looking at emit_log_char()
I think it is. The buffer can wrap around so in that case end < start,
which just end-start won't handle here.
johannes
next prev parent reply other threads:[~2011-11-18 18:46 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 10:18 [PATCH] tracing: add trace console Johannes Berg
2011-11-16 14:15 ` Steven Rostedt
2011-11-16 14:25 ` Peter Zijlstra
2011-11-16 14:30 ` Johannes Berg
2011-11-16 14:41 ` Peter Zijlstra
2011-11-16 14:48 ` Steven Rostedt
2011-11-16 14:50 ` Peter Zijlstra
2011-11-16 14:51 ` Johannes Berg
2011-11-16 15:17 ` Steven Rostedt
2011-11-16 14:32 ` Thomas Gleixner
2011-11-16 14:35 ` Frederic Weisbecker
2011-11-16 15:09 ` [PATCH v2] " Johannes Berg
2011-11-16 15:17 ` Peter Zijlstra
2011-11-16 15:19 ` Steven Rostedt
2011-11-16 15:10 ` [PATCH] " Christoph Hellwig
2011-11-16 15:17 ` Johannes Berg
2011-11-16 16:41 ` Steven Rostedt
2011-11-16 16:45 ` Johannes Berg
2011-11-16 17:00 ` Steven Rostedt
2011-11-16 17:05 ` Steven Rostedt
2011-11-16 18:33 ` Johannes Berg
2011-11-16 19:57 ` Steven Rostedt
2011-11-16 20:12 ` Johannes Berg
2011-11-16 21:25 ` [PATCH] printk: add console output tracing Johannes Berg
2011-11-17 1:01 ` Steven Rostedt
2011-11-17 14:55 ` Frederic Weisbecker
2011-11-17 14:57 ` Johannes Berg
2011-11-17 15:00 ` Frederic Weisbecker
2011-11-17 15:17 ` Steven Rostedt
2011-11-17 15:21 ` [PATCH v2] " Johannes Berg
2011-11-18 18:44 ` Frederic Weisbecker
2011-11-18 18:46 ` Johannes Berg [this message]
2011-11-18 18:54 ` Frederic Weisbecker
2011-11-18 18:59 ` Johannes Berg
2011-11-23 13:16 ` Frederic Weisbecker
2011-11-24 13:21 ` Johannes Berg
2011-11-24 15:45 ` Frederic Weisbecker
2011-11-24 19:00 ` Johannes Berg
2011-11-25 17:43 ` Frederic Weisbecker
2011-11-25 18:11 ` Johannes Berg
2011-11-24 19:03 ` [PATCH v3] " Johannes Berg
2011-11-25 17:41 ` Frederic Weisbecker
2011-12-02 18:05 ` Steven Rostedt
2012-02-13 17:30 ` Steven Rostedt
2012-02-13 17:33 ` Johannes Berg
2012-02-13 17:42 ` Steven Rostedt
2012-02-17 13:52 ` [tip:perf/core] printk/tracing: Add " tip-bot for Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321641975.10266.73.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®