From: Seth Forshee <seth.forshee@canonical.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] dell-wmi: Change debug statements from pr_info to pr_debug
Date: Mon, 21 Nov 2011 14:48:56 -0600 [thread overview]
Message-ID: <1321908536-5163-1-git-send-email-seth.forshee@canonical.com> (raw)
The debug statements reporting unkown WMI and hotkey events are
polluting the log in some systems and generating unnecessary
concern from users. Change these to pr_debug to hide them normally
while keeping them available for when they're needed.
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
drivers/platform/x86/dell-wmi.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index fa9a217..1881e28 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -165,8 +165,8 @@ static void dell_wmi_notify(u32 value, void *context)
u16 *buffer_entry = (u16 *)obj->buffer.pointer;
if (dell_new_hk_type && (buffer_entry[1] != 0x10)) {
- pr_info("Received unknown WMI event (0x%x)\n",
- buffer_entry[1]);
+ pr_debug("Received unknown WMI event (0x%x)\n",
+ buffer_entry[1]);
kfree(obj);
return;
}
@@ -179,7 +179,7 @@ static void dell_wmi_notify(u32 value, void *context)
key = sparse_keymap_entry_from_scancode(dell_wmi_input_dev,
reported_key);
if (!key) {
- pr_info("Unknown key %x pressed\n", reported_key);
+ pr_debug("Unknown key %x pressed\n", reported_key);
} else if ((key->keycode == KEY_BRIGHTNESSUP ||
key->keycode == KEY_BRIGHTNESSDOWN) && acpi_video) {
/* Don't report brightness notifications that will also
--
1.7.5.4
next reply other threads:[~2011-11-21 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 20:48 Seth Forshee [this message]
2011-11-21 20:52 ` Matthew Garrett
2011-11-21 21:10 ` Corentin Chary
2011-11-21 21:14 ` Seth Forshee
2011-11-21 21:18 ` Matthew Garrett
2011-11-21 22:29 ` Seth Forshee
2011-11-21 22:32 ` Matthew Garrett
2011-12-07 16:43 ` Seth Forshee
2011-12-07 20:22 ` Rezwanul_Kabir
2011-12-07 21:15 ` Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321908536-5163-1-git-send-email-seth.forshee@canonical.com \
--to=seth.forshee@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®