mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: ralf@linux-mips.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	David Daney <david.daney@cavium.com>
Subject: [PATCH 0/2] Stop some of the abuse of BUG() where compile time checks should be used.
Date: Mon, 21 Nov 2011 17:31:04 -0800	[thread overview]
Message-ID: <1321925466-11280-1-git-send-email-ddaney.cavm@gmail.com> (raw)

From: David Daney <david.daney@cavium.com>

After some, perhaps justified, reluctance to merge dummy symbol
definitions  containing BUG() into header files, I propose these patches
instead.

We define a new compile time assertion BUILD_BUG_ON_USED() that can be
used in places were we expect the compiler's dead code elimination to
get rid of code.  This happens mostly in code dealing with huge pages,
but in other places as well.

The first patch adds BUILD_BUG_ON_USED(), the second gets rid of one
of the main abusers of BUG().

David Daney (2):
  kernel.h: Add BUILD_BUG_ON_USED() macro.
  hugetlb: Replace BUG() with BUILD_BUG_ON_USED() for dummy
    definitions.

 include/linux/compiler-gcc4.h |    1 +
 include/linux/compiler.h      |    4 +++-
 include/linux/hugetlb.h       |   15 ++++++++-------
 include/linux/kernel.h        |   16 ++++++++++++++++
 4 files changed, 28 insertions(+), 8 deletions(-)

-- 
1.7.2.3


             reply	other threads:[~2011-11-22  1:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22  1:31 David Daney [this message]
2011-11-22  1:31 ` [PATCH 1/2] kernel.h: Add BUILD_BUG_ON_USED() macro David Daney
2011-11-22  4:35   ` Linus Torvalds
2011-11-22  1:31 ` [PATCH 2/2] hugetlb: Replace BUG() with BUILD_BUG_ON_USED() for dummy definitions David Daney
2011-11-22  8:42 ` [PATCH 0/2] Stop some of the abuse of BUG() where compile time checks should be used DM
2011-11-22 17:13   ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321925466-11280-1-git-send-email-ddaney.cavm@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david.daney@cavium.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=rientjes@google.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®