From: Johannes Weiner <hannes@cmpxchg.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Michal Hocko <mhocko@suse.cz>,
Balbir Singh <bsingharora@gmail.com>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [patch 3/8] mm: memcg: clean up fault accounting
Date: Wed, 23 Nov 2011 16:42:26 +0100 [thread overview]
Message-ID: <1322062951-1756-4-git-send-email-hannes@cmpxchg.org> (raw)
In-Reply-To: <1322062951-1756-1-git-send-email-hannes@cmpxchg.org>
From: Johannes Weiner <jweiner@redhat.com>
The fault accounting functions have a single, memcg-internal user, so
they don't need to be global. In fact, their one-line bodies can be
directly folded into the caller. And since faults happen one at a
time, use this_cpu_inc() directly instead of this_cpu_add(foo, 1).
Signed-off-by: Johannes Weiner <jweiner@redhat.com>
---
mm/memcontrol.c | 14 ++------------
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 473b99f..d825af9 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -589,16 +589,6 @@ static void mem_cgroup_swap_statistics(struct mem_cgroup *memcg,
this_cpu_add(memcg->stat->count[MEM_CGROUP_STAT_SWAPOUT], val);
}
-void mem_cgroup_pgfault(struct mem_cgroup *memcg, int val)
-{
- this_cpu_add(memcg->stat->events[MEM_CGROUP_EVENTS_PGFAULT], val);
-}
-
-void mem_cgroup_pgmajfault(struct mem_cgroup *memcg, int val)
-{
- this_cpu_add(memcg->stat->events[MEM_CGROUP_EVENTS_PGMAJFAULT], val);
-}
-
static unsigned long mem_cgroup_read_events(struct mem_cgroup *memcg,
enum mem_cgroup_events_index idx)
{
@@ -913,10 +903,10 @@ void mem_cgroup_count_vm_event(struct mm_struct *mm, enum vm_event_item idx)
switch (idx) {
case PGMAJFAULT:
- mem_cgroup_pgmajfault(memcg, 1);
+ this_cpu_inc(memcg->stat->events[MEM_CGROUP_EVENTS_PGFAULT]);
break;
case PGFAULT:
- mem_cgroup_pgfault(memcg, 1);
+ this_cpu_inc(memcg->stat->events[MEM_CGROUP_EVENTS_PGMAJFAULT]);
break;
default:
BUG();
--
1.7.6.4
next prev parent reply other threads:[~2011-11-23 15:43 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 15:42 [patch 0/8] mm: memcg fixlets for 3.3 Johannes Weiner
2011-11-23 15:42 ` [patch 1/8] mm: oom_kill: remove memcg argument from oom_kill_task() Johannes Weiner
2011-11-23 22:35 ` David Rientjes
2011-11-23 23:57 ` KAMEZAWA Hiroyuki
2011-11-24 9:07 ` Michal Hocko
2011-11-28 0:37 ` Balbir Singh
2011-11-23 15:42 ` [patch 2/8] mm: unify remaining mem_cont, mem, etc. variable names to memcg Johannes Weiner
2011-11-23 22:40 ` David Rientjes
2011-11-23 23:58 ` KAMEZAWA Hiroyuki
2011-11-24 9:17 ` Michal Hocko
2011-11-28 0:42 ` Balbir Singh
2011-11-23 15:42 ` Johannes Weiner [this message]
2011-11-24 0:00 ` [patch 3/8] mm: memcg: clean up fault accounting KAMEZAWA Hiroyuki
2011-11-24 9:33 ` Michal Hocko
2011-11-24 9:51 ` Johannes Weiner
2011-11-28 0:45 ` Balbir Singh
2011-11-23 15:42 ` [patch 4/8] mm: memcg: lookup_page_cgroup (almost) never returns NULL Johannes Weiner
2011-11-24 0:01 ` KAMEZAWA Hiroyuki
2011-11-24 9:52 ` Michal Hocko
2011-11-24 10:05 ` Johannes Weiner
2011-11-24 10:26 ` Michal Hocko
2011-11-28 9:15 ` Johannes Weiner
2011-11-28 9:34 ` Johannes Weiner
2011-11-28 10:12 ` Michal Hocko
2011-11-28 7:03 ` Balbir Singh
2011-11-28 9:17 ` Johannes Weiner
2011-11-23 15:42 ` [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge() Johannes Weiner
2011-11-24 0:04 ` KAMEZAWA Hiroyuki
2011-11-24 9:04 ` Johannes Weiner
2011-11-24 10:30 ` Michal Hocko
2011-11-24 11:58 ` Johannes Weiner
2011-11-23 15:42 ` [patch 6/8] mm: memcg: remove unneeded checks from uncharge_page() Johannes Weiner
2011-11-24 0:06 ` KAMEZAWA Hiroyuki
2011-11-24 9:06 ` Johannes Weiner
2011-11-24 10:34 ` Michal Hocko
2011-11-23 15:42 ` [patch 7/8] mm: memcg: modify PageCgroupAcctLRU non-atomically Johannes Weiner
2011-11-23 18:52 ` Hugh Dickins
2011-11-24 8:53 ` Johannes Weiner
2011-11-24 0:09 ` KAMEZAWA Hiroyuki
2011-11-24 8:55 ` Johannes Weiner
2011-11-23 15:42 ` [patch 8/8] mm: memcg: modify PageCgroupCache non-atomically Johannes Weiner
2011-11-24 0:13 ` KAMEZAWA Hiroyuki
2011-11-24 9:13 ` Johannes Weiner
2011-11-24 6:09 ` [patch 0/8] mm: memcg fixlets for 3.3 Balbir Singh
2011-11-24 9:45 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322062951-1756-4-git-send-email-hannes@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®