From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756845Ab1KWPnH (ORCPT ); Wed, 23 Nov 2011 10:43:07 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:44823 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756752Ab1KWPnC (ORCPT ); Wed, 23 Nov 2011 10:43:02 -0500 From: Johannes Weiner To: Andrew Morton Cc: KAMEZAWA Hiroyuki , Michal Hocko , Balbir Singh , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [patch 6/8] mm: memcg: remove unneeded checks from uncharge_page() Date: Wed, 23 Nov 2011 16:42:29 +0100 Message-Id: <1322062951-1756-7-git-send-email-hannes@cmpxchg.org> X-Mailer: git-send-email 1.7.6.4 In-Reply-To: <1322062951-1756-1-git-send-email-hannes@cmpxchg.org> References: <1322062951-1756-1-git-send-email-hannes@cmpxchg.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Weiner mem_cgroup_uncharge_page() is only called on either freshly allocated pages without page->mapping or on rmapped PageAnon() pages. There is no need to check for a page->mapping that is not an anon_vma. Signed-off-by: Johannes Weiner --- mm/memcontrol.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 0d10be4..b9a3b94 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2989,8 +2989,6 @@ void mem_cgroup_uncharge_page(struct page *page) /* early check. */ if (page_mapped(page)) return; - if (page->mapping && !PageAnon(page)) - return; __mem_cgroup_uncharge_common(page, MEM_CGROUP_CHARGE_TYPE_MAPPED); } -- 1.7.6.4